Issue 631163002: Clean up ifdef around FilePath creation in /src/third_party

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 631163002: Clean up ifdef around FilePath creation in /src/third_party (Closed)

Created:
6 years, 2 months ago by anujsharma

Modified:
6 years, 2 months ago

Reviewers:
michaeln

CC:
chromium-reviews, MRV, cmumford

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Clean up ifdef around FilePath creation in /src/third_party BUG=102853 Committed: https://crrev.com/e8d8e17216fb015f8b23911bd44a84aee697d858 Cr-Commit-Position: refs/heads/master@{#298644}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	third_party/leveldatabase/env_chromium.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2014/10/07 21:42:00, michaeln wrote: > lgtm Thanks michaeln for lgtm.

6 years, 2 months ago (2014-10-08 01:14:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631163002/1

6 years, 2 months ago (2014-10-08 01:18:01 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as a5120e27820426cf8e8f9a4d040ff9e230a5bc51

6 years, 2 months ago (2014-10-08 02:12:33 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-08 02:13:10 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e8d8e17216fb015f8b23911bd44a84aee697d858
Cr-Commit-Position: refs/heads/master@{#298644}