Fix all type errors in image_loader.

ui/file_manager/image_loader/request.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
+ * @typedef {{
+ *   cache: (boolean|undefined),
+ *   priority: (number|undefined),
+ *   taskId: number,
+ *   timestamp: (number|undefined),
+ *   url: string
+ * }}
+ */
+var LoadImageRequest;

[fukino, 2014/10/07 09:52:45]

This type defines how the request object given through inter-extension messaging
looks like.

+
+/**
  * Creates and starts downloading and then resizing of the image. Finally,
  * returns the image using the callback.
  *
  * @param {string} id Request ID.
  * @param {Cache} cache Cache object.
- * @param {Object} request Request message as a hash array.
+ * @param {LoadImageRequest} request Request message as a hash array.
  * @param {function(Object)} callback Callback used to send the response.
  * @constructor
  */
 function Request(id, cache, request, callback) {
   /**
    * @type {string}
    * @private
    */
   this.id_ = id;
 
   /**
    * @type {Cache}
    * @private
    */
   this.cache_ = cache;
 
   /**
-   * @type {Object}
+   * @type {LoadImageRequest}
    * @private
    */
   this.request_ = request;
 
   /**
    * @type {function(Object)}
    * @private
    */
   this.sendResponse_ = callback;
 
@@ skipping 194 matching lines @@
  *
  * @param {string} url URL to the resource to be fetched.
  * @param {function(string, Blob)} onSuccess Success callback with the content
  *     type and the fetched data.
  * @param {function()} onFailure Failure callback.
  */
 AuthorizedXHR.prototype.load = function(url, onSuccess, onFailure) {
   this.aborted_ = false;
 
   // Do not call any callbacks when aborting.
-  var onMaybeSuccess = function(contentType, response) {
-    if (!this.aborted_)
-      onSuccess(contentType, response);
-  }.bind(this);
+  var onMaybeSuccess = /** @type {function(string, Blob)} */ (
+      function(contentType, response) {
+        if (!this.aborted_)
+          onSuccess(contentType, response);
+      }.bind(this));
 
-  var onMaybeFailure = function(opt_code) {
-    if (!this.aborted_)
-      onFailure();
-  }.bind(this);
+  var onMaybeFailure = /** @type {function(number=)} */ (

[mtomasz, 2014/10/07 09:56:15]

Sometimes we use number|underfined, but sometimes number=. Are both correct and
interchangeable? Shall we use one? 

[fukino, 2014/10/07 10:49:44]

number= can be used only for optional parameter. (number|undefined) is also
valid, but can be used more generally. I think number= is better for optional
parameters because this dedicated form has more specific meaning.

[mtomasz, 2014/10/07 10:54:29]

Got it. Thanks for the explanation!

+      function(opt_code) {
+        if (!this.aborted_)
+          onFailure();
+      }.bind(this));
 
   // Fetches the access token and makes an authorized call. If refresh is true,
   // then forces refreshing the access token.
   var requestTokenAndCall = function(refresh, onInnerSuccess, onInnerFailure) {
     chrome.fileManagerPrivate.requestAccessToken(refresh, function(token) {
       if (this.aborted_)
         return;
       if (!token) {
         onInnerFailure();
         return;
@@ skipping 12 matching lines @@
 
   // Do not request a token for local resources, since it is not necessary.
   if (/^filesystem:/.test(url)) {
     // The query parameter is workaround for
     // crbug.com/379678, which force to obtain the latest contents of the image.
     var noCacheUrl = url + '?nocache=' + Date.now();
     this.xhr_ = AuthorizedXHR.load_(
         null,
         noCacheUrl,
         onMaybeSuccess,
-        onMaybeSuccess);
+        onMaybeFailure);

[fukino, 2014/10/07 09:52:45]

This was changed onMaybeSuccess unintentionally, so reverted it.

     return;
   }
 
   // Make the request with reusing the current token. If it fails, then retry.
   requestTokenAndCall(false, onMaybeSuccess, maybeRetryCall);
 };
 
 /**
  * Fetches data using authorized XmlHttpRequest with the provided OAuth2 token.
  * If the token is invalid, the request will fail.
@@ skipping 136 matching lines @@
   this.image_.src = 'data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAA' +
       'ABAAEAAAICTAEAOw==';
 
   this.xhr_.onload = function() {};
   this.xhr_.abort();
 
   // Dispose memory allocated by Canvas.
   this.canvas_.width = 0;
   this.canvas_.height = 0;
 };