Fix all type errors in image_loader.

ui/file_manager/image_loader/image_loader.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * Loads and resizes an image.
  * @constructor
  */
@@ skipping 16 matching lines @@
   // scheduler.
   chrome.fileManagerPrivate.getVolumeMetadataList(function(volumeMetadataList) {
     var initPromises = volumeMetadataList.map(function(volumeMetadata) {
       var requestPromise = new Promise(function(callback) {
         chrome.fileManagerPrivate.requestFileSystem(
             volumeMetadata.volumeId,
             callback);
       });
       return requestPromise;
     });
-    initPromises.push(new Promise(this.cache_.initialize.bind(this.cache_)));
+    initPromises.push(new Promise(function(resolve, reject) {

[fukino, 2014/10/07 09:52:44]

The executor function which is given to Promise constructor needs two arguments
(according to
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-executor), so I
rewrote like this.

+      this.cache_.initialize(resolve);
+    }.bind(this)));
 
     // After all initialization promises are done, start the scheduler.
     Promise.all(initPromises).then(this.scheduler_.start.bind(this.scheduler_));
 
     // Listen for mount events, and grant permissions to volumes being mounted.
     chrome.fileManagerPrivate.onMountCompleted.addListener(
         function(event) {
           if (event.eventType == 'mount' && event.status == 'success') {
             chrome.fileManagerPrivate.requestFileSystem(
                 event.volumeMetadata.volumeId, function() {});
           }
         });
   }.bind(this));
 
   // Listen for incoming requests.
-  chrome.extension.onMessageExternal.addListener(
+  chrome.runtime.onMessageExternal.addListener(
       function(request, sender, sendResponse) {
         if (ImageLoader.ALLOWED_CLIENTS.indexOf(sender.id) !== -1) {
           // Sending a response may fail if the receiver already went offline.
           // This is not an error, but a normal and quite common situation.
           var failSafeSendResponse = function(response) {
             try {
               sendResponse(response);
             }
             catch (e) {
               // Ignore the error.
             }
           };
-          return this.onMessage_(sender.id, request, failSafeSendResponse);
+          return this.onMessage_(sender.id,
+                                 /** @type {LoadImageRequest} */ (request),
+                                 failSafeSendResponse);
         }
       }.bind(this));
 }
 
 /**
  * List of extensions allowed to perform image requests.
  *
  * @const
  * @type {Array.<string>}
  */
 ImageLoader.ALLOWED_CLIENTS = [
   'hhaomjibdihmijegdhdafkllkbggdgoj',  // File Manager's extension id.
   'nlkncpkkdoccmpiclbokaimcnedabhhm'  // Gallery extension id.
 ];
 
 /**
  * Handles a request. Depending on type of the request, starts or stops
  * an image task.
  *
  * @param {string} senderId Sender's extension id.
- * @param {Object} request Request message as a hash array.
+ * @param {LoadImageRequest} request Request message as a hash array.
  * @param {function(Object)} callback Callback to be called to return response.
  * @return {boolean} True if the message channel should stay alive until the
  *     callback is called.
  * @private
  */
 ImageLoader.prototype.onMessage_ = function(senderId, request, callback) {
   var requestId = senderId + ':' + request.taskId;
   if (request.cancel) {
     // Cancel a task.
     this.scheduler_.remove(requestId);
@@ skipping 126 matching lines @@
   targetContext.translate(target.width / 2, target.height / 2);
   targetContext.rotate(orientation * Math.PI / 2);
   targetContext.drawImage(
       source,
       0, 0,
       source.width, source.height,
       -drawImageWidth / 2, -drawImageHeight / 2,
       drawImageWidth, drawImageHeight);
   targetContext.restore();
 };