Fix all type errors in image_loader.

Fix all type errors in image_loader.

BUG=406995
TEST=run browser_tests

Committed: https://crrev.com/c41cfec3285c48e77f20dd0f3bf356246797a986
Cr-Commit-Position: refs/heads/master@{#298449}

[fukino, 2014-10-07 09:52:44]

fukino@chromium.org changed reviewers:
+ mtomasz@chromium.org

[fukino, 2014-10-07 09:52:45]

Tomasz, could you take a look? Thanks!

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/image_loader.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/image_loader.js:37: initPromises.push(new
Promise(function(resolve, reject) {
The executor function which is given to Promise constructor needs two arguments
(according to
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise-executor), so I
rewrote like this.

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/image_loader_client.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/image_loader_client.js:90:
chrome.runtime.sendMessage(
I think we can use chrome.runtime.sendMessage safely now (since Chrome 26).

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/request.js:16: var LoadImageRequest;
This type defines how the request object given through inter-extension messaging
looks like.

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/request.js:300: onMaybeFailure);
This was changed onMaybeSuccess unintentionally, so reverted it.

[mtomasz, 2014-10-07 09:56:16]

lgtm with a nit.

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/request.js:263: var onMaybeFailure = /** @type
{function(number=)} */ (
Sometimes we use number|underfined, but sometimes number=. Are both correct and
interchangeable? Shall we use one?

[fukino, 2014-10-07 10:49:44]

Thanks!

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/request.js:263: var onMaybeFailure = /** @type
{function(number=)} */ (
On 2014/10/07 09:56:15, mtomasz wrote:
> Sometimes we use number|underfined, but sometimes number=. Are both correct
and
> interchangeable? Shall we use one? 

number= can be used only for optional parameter. (number|undefined) is also
valid, but can be used more generally. I think number= is better for optional
parameters because this dedicated form has more specific meaning.

[mtomasz, 2014-10-07 10:54:30]

still lgtm

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
File ui/file_manager/image_loader/request.js (right):

https://codereview.chromium.org/631143002/diff/1/ui/file_manager/image_loader...
ui/file_manager/image_loader/request.js:263: var onMaybeFailure = /** @type
{function(number=)} */ (
On 2014/10/07 10:49:44, fukino wrote:
> On 2014/10/07 09:56:15, mtomasz wrote:
> > Sometimes we use number|underfined, but sometimes number=. Are both correct
> and
> > interchangeable? Shall we use one? 
> 
> number= can be used only for optional parameter. (number|undefined) is also
> valid, but can be used more generally. I think number= is better for optional
> parameters because this dedicated form has more specific meaning.

Got it. Thanks for the explanation!

[fukino, 2014-10-07 10:57:51]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-10-07 10:58:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/631143002/1

[commit-bot: I haz the power, 2014-10-07 13:00:54]

Committed patchset #1 (id:1) as dbd86328ae28c0d2c591d911a7a8d8e5b0c720b3

[commit-bot: I haz the power, 2014-10-07 13:01:31]

Patchset 1 (id:??) landed as
https://crrev.com/c41cfec3285c48e77f20dd0f3bf356246797a986
Cr-Commit-Position: refs/heads/master@{#298449}