Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 631133003: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/workers (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/workers This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -95 lines) Patch
M Source/core/workers/AbstractWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.h View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerThread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/workers/SharedWorker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/workers/SharedWorkerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/workers/WorkerClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerEventQueue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 5 chunks +20 lines, -20 lines 0 comments Download
M Source/core/workers/WorkerInspectorProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerLocation.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/workers/WorkerNavigator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/workers/WorkerScriptLoader.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/workers/WorkerThreadStartupData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:20:57 UTC) #2
Mike West
rs lgtm.
6 years, 2 months ago (2014-10-07 12:56:09 UTC) #4
MRV
On 2014/10/07 12:56:09, Mike West wrote: > rs lgtm. Thank you. Mr. Mike
6 years, 2 months ago (2014-10-07 12:59:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631133003/1
6 years, 2 months ago (2014-10-07 12:59:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 14:12:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183335

Powered by Google App Engine
This is Rietveld 408576698