Issue 631093003: [turbofan] Fix lowering of typed loads/stores.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 631093003: [turbofan] Fix lowering of typed loads/stores. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer

Modified:
6 years, 2 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Fix lowering of typed loads/stores. Only JSLoadProperty/JSStoreProperty nodes with external typed arrays can be lowered to LoadElement/StoreElement, because lowering of non-external typed arrays would require a map check. TEST=cctest,unittests,mjsunit R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24426

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+560 lines, -65 lines)			Patch
M	src/compiler/access-builder.cc	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/compiler/js-typed-lowering.cc	View	2 chunks	+40 lines, -48 lines	0 comments	Download
M	src/compiler/simplified-operator.h	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	src/compiler/simplified-operator.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/factory.cc	View	3 chunks	+40 lines, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/unittests/compiler/graph-unittest.h	View	3 chunks	+25 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/graph-unittest.cc	View	5 chunks	+215 lines, -1 line	0 comments	Download
M	test/unittests/compiler/js-builtin-reducer-unittest.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
A	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 chunk	+164 lines, -0 lines	0 comments	Download
M	test/unittests/test-utils.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	test/unittests/test-utils.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	test/unittests/unittests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

6 years, 2 months ago (2014-10-07 07:37:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24426 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages