Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 631053003: Replacing the OVERRIDE with override and FINAL with final in content/browser/geolocation (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/geolocation This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/175d645623f98024fd94572f6229de455b30048a Cr-Commit-Position: refs/heads/master@{#298429}

Patch Set 1 #

Patch Set 2 : Resolved mac issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M content/browser/geolocation/empty_wifi_data_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/location_arbitrator_impl_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/location_provider_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/location_provider_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/mock_location_arbitrator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/mock_location_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/geolocation/mock_location_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/network_location_request.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_chromeos.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_chromeos_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_common_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_corewlan_mac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/wifi_data_provider_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 03:44:16 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 03:57:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631053003/1
6 years, 2 months ago (2014-10-07 04:25:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/20974)
6 years, 2 months ago (2014-10-07 05:22:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631053003/1
6 years, 2 months ago (2014-10-07 05:59:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/21012)
6 years, 2 months ago (2014-10-07 07:14:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631053003/20001
6 years, 2 months ago (2014-10-07 07:21:42 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as cce2977a6b3622082129160957de46ae69b38c28
6 years, 2 months ago (2014-10-07 08:49:44 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 08:50:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/175d645623f98024fd94572f6229de455b30048a
Cr-Commit-Position: refs/heads/master@{#298429}

Powered by Google App Engine
This is Rietveld 408576698