Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 631013003: Replacing the OVERRIDE with override and FINAL with final in content/browser/frame_host (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in content/browser/frame_host This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/383f53b34d909937b438a8ffaadfd20bc15837e4 Cr-Commit-Position: refs/heads/master@{#298392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -334 lines) Patch
M content/browser/frame_host/frame_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/frame_tree_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 2 chunks +37 lines, -37 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/frame_host/interstitial_page_navigator_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.h View 1 chunk +47 lines, -47 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 1 chunk +49 lines, -49 lines 0 comments Download
M content/browser/frame_host/navigator_impl.h View 2 chunks +12 lines, -12 lines 0 comments Download
M content/browser/frame_host/popup_menu_helper_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +30 lines, -30 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +60 lines, -60 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +53 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 03:43:00 UTC) #2
Avi (use Gerrit)
Stampity stamp LGTM
6 years, 2 months ago (2014-10-07 03:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/631013003/1
6 years, 2 months ago (2014-10-07 04:25:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9694a70f9fd9d43c3ac725c69d5d32054bb0b09f
6 years, 2 months ago (2014-10-07 05:56:44 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:57:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/383f53b34d909937b438a8ffaadfd20bc15837e4
Cr-Commit-Position: refs/heads/master@{#298392}

Powered by Google App Engine
This is Rietveld 408576698