Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 630983003: Declaring the weak_ptr_factory in proper order in src/components (Closed)

Created:
6 years, 2 months ago by PBS
Modified:
6 years, 2 months ago
Reviewers:
blundell
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Declaring the weak_ptr_factory in proper order in src/components Cleaning up weak_ptr_factory destruction order. WeakPtrFactory should remain the last member so it'll be destroyed and invalidate its weak pointers before any other members are destroyed. BUG=303818 Committed: https://crrev.com/4c90c51fa52659f3f1fa59d1d78b57bca661dfc5 Cr-Commit-Position: refs/heads/master@{#298842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.h View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/browser/data_reduction_proxy_statistics_prefs.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/metrics/metrics_service.h View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (2 generated)
PBS
PTAL
6 years, 2 months ago (2014-10-08 03:40:05 UTC) #2
blundell
Hi, Did you sign the CLA? I don't see your name listed as having signed ...
6 years, 2 months ago (2014-10-08 10:54:08 UTC) #3
PBS
On 2014/10/08 10:54:08, blundell wrote: > Hi, > > Did you sign the CLA? I ...
6 years, 2 months ago (2014-10-08 11:49:54 UTC) #4
PBS
On 2014/10/08 11:49:54, Pramod Begur wrote: > On 2014/10/08 10:54:08, blundell wrote: > > Hi, ...
6 years, 2 months ago (2014-10-09 03:24:13 UTC) #5
blundell
On 2014/10/09 03:24:13, Pramod Begur wrote: > On 2014/10/08 11:49:54, Pramod Begur wrote: > > ...
6 years, 2 months ago (2014-10-09 05:52:56 UTC) #6
PBS
On 2014/10/09 05:52:56, blundell wrote: > On 2014/10/09 03:24:13, Pramod Begur wrote: > > On ...
6 years, 2 months ago (2014-10-09 07:51:50 UTC) #7
blundell
LGTM, thanks! You're good to go.
6 years, 2 months ago (2014-10-09 08:02:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630983003/1
6 years, 2 months ago (2014-10-09 08:36:18 UTC) #10
PBS
On 2014/10/09 08:02:35, blundell wrote: > LGTM, thanks! > > You're good to go. Thanks
6 years, 2 months ago (2014-10-09 08:41:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as b0ec39b4127be4b95e48fd1f3767dcb9d452887b
6 years, 2 months ago (2014-10-09 10:56:49 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 10:57:46 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c90c51fa52659f3f1fa59d1d78b57bca661dfc5
Cr-Commit-Position: refs/heads/master@{#298842}

Powered by Google App Engine
This is Rietveld 408576698