Deprecate v8::External::New without Isolate parameter

Deprecate v8::External::New without Isolate parameter

R=bmeurer@chromium.org, machenbach@chromium.org, svenpanne@chromium.org
LOG=y
BUG=none

Committed: https://code.google.com/p/v8/source/detail?r=17869

[Benedikt Meurer, 2013-11-18 11:53:40]

LGTM.

BTW: Isn't that LOG=y only relevant if a BUG number is given?

[jochen (gone - plz use gerrit), 2013-11-18 11:55:20]

no idea?

[Benedikt Meurer, 2013-11-18 11:59:16]

On 2013/11/18 11:55:20, jochen wrote:
> no idea?

Please talk to machenbach@ first, since this is IMHO something that should show
up in ChangeLog.

[jochen (gone - plz use gerrit), 2013-11-18 12:01:45]

^^^ machenbach?

[Michael Achenbach, 2013-11-18 12:13:45]

LOG=y means the first line of this commit message will be added to the
ChangeLog. In this case "Deprecate v8::External::New without Isolate
parameter.". A bug number is not required, but if given, will be automatically
added. If this change is interesting for embedders, then this looks alright.
LGTM.

[Benedikt Meurer, 2013-11-18 12:14:36]

On 2013/11/18 12:13:45, machenbach wrote:
> LOG=y means the first line of this commit message will be added to the
> ChangeLog. In this case "Deprecate v8::External::New without Isolate
> parameter.". A bug number is not required, but if given, will be automatically
> added. If this change is interesting for embedders, then this looks alright.
> LGTM.

Ok, great. :-)

[Sven Panne, 2013-11-18 12:23:29]

LGTM, too. Are the call sites for the deprecated entry already fixed in Chrome?
Just to make sure that we don't pile up more work while our deprecations are
disabled... >:-(

[jochen (gone - plz use gerrit), 2013-11-18 12:43:47]

blink is converted, the CL for chrome is currently in the CQ.
I'll wait until it lands before commiting this

[jochen (gone - plz use gerrit), 2013-11-19 12:20:14]

Committed patchset #1 manually as r17869 (presubmit successful).