Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: runtime/vm/stack_frame_mips.h

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/stack_frame_ia32.h ('k') | runtime/vm/stack_frame_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stack_frame_mips.h
===================================================================
--- runtime/vm/stack_frame_mips.h (revision 30084)
+++ runtime/vm/stack_frame_mips.h (working copy)
@@ -14,19 +14,24 @@
| current RA | (PC of current frame)
| callee's PC marker |
+--------------------+
-Current frame | ... | <- SP of current frame
- | first local |
- | caller's PP |
+Current frame | ... T| <- SP of current frame
+ | first local T|
+ | caller's PP T|
| caller's FP | <- FP of current frame
| caller's RA | (PC of caller frame)
| PC marker | (current frame's code entry + offset)
+--------------------+
Caller frame | last parameter | <- SP of caller frame
| ... |
+
+ T against a slot indicates it needs to be traversed during GC.
*/
static const int kDartFrameFixedSize = 4; // PP, FP, RA, PC marker.
static const int kSavedPcSlotFromSp = -2;
+
+static const int kFirstObjectSlotFromFp = -2; // Used by GC to traverse stack.
+
static const int kFirstLocalSlotFromFp = -2;
static const int kSavedCallerPpSlotFromFp = -1;
static const int kSavedCallerFpSlotFromFp = 0;
@@ -42,4 +47,3 @@
} // namespace dart
#endif // VM_STACK_FRAME_MIPS_H_
-
« no previous file with comments | « runtime/vm/stack_frame_ia32.h ('k') | runtime/vm/stack_frame_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698