runtime/vm/object_x64_test.cc - Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_x64_test.cc

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_x64_test.cc

===================================================================

--- runtime/vm/object_x64_test.cc (revision 30084)

+++ runtime/vm/object_x64_test.cc (working copy)

@@ -34,9 +34,10 @@

void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {

const String& string_object =

String::ZoneHandle(String::New(str, Heap::kOld));

- __ EnterDartFrame(0);

+ __ pushq(PP); // Save caller's pool pointer and load a new one here.

+ __ LoadPoolPointer(PP);

__ LoadObject(RAX, string_object, PP);

- __ LeaveFrameWithPP();

+ __ popq(PP); // Restore caller's pool pointer.

__ ret();

}

« no previous file with comments | « runtime/vm/instructions_x64_test.cc ('k') | runtime/vm/stack_frame.cc » ('j') | no next file with comments »