Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: runtime/vm/instructions_x64_test.cc

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/instructions_x64_test.cc
===================================================================
--- runtime/vm/instructions_x64_test.cc (revision 29988)
+++ runtime/vm/instructions_x64_test.cc (working copy)
@@ -28,10 +28,11 @@
ASSEMBLER_TEST_GENERATE(Jump, assembler) {
- __ EnterDartFrame(0); // 20 bytes
+ __ pushq(PP); // Save caller's pool pointer and load a new one here.
+ __ LoadPoolPointer(PP);
__ JmpPatchable(&StubCode::InstanceFunctionLookupLabel(), PP);
__ JmpPatchable(&StubCode::AllocateArrayLabel(), PP);
- __ LeaveFrameWithPP();
+ __ popq(PP); // Restore caller's pool pointer.
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698