Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: runtime/vm/assembler_x64_test.cc

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64_test.cc
===================================================================
--- runtime/vm/assembler_x64_test.cc (revision 29988)
+++ runtime/vm/assembler_x64_test.cc (working copy)
@@ -1631,7 +1631,7 @@
__ shufps(XMM0, XMM0, Immediate(0x0));
__ negateps(XMM0);
__ shufps(XMM0, XMM0, Immediate(0xAA)); // Copy third lane into all 4 lanes.
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -1650,7 +1650,7 @@
__ shufps(XMM0, XMM0, Immediate(0x0));
__ absps(XMM0);
__ shufps(XMM0, XMM0, Immediate(0xAA)); // Copy third lane into all 4 lanes.
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -1667,7 +1667,7 @@
__ set1ps(XMM0, RAX, Immediate(bit_cast<int32_t, float>(12.3f)));
__ zerowps(XMM0);
__ shufps(XMM0, XMM0, Immediate(0xFF)); // Copy the W lane which is now 0.0.
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -1792,7 +1792,7 @@
__ pushq(RAX);
__ movss(Address(RSP, 0), XMM0);
__ popq(RAX);
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -2211,11 +2211,11 @@
__ CompareObject(RCX, smi, PP);
__ j(NOT_EQUAL, &fail);
__ movl(RAX, Immediate(1)); // OK
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
__ Bind(&fail);
__ movl(RAX, Immediate(0)); // Fail.
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -2433,7 +2433,7 @@
FieldAddress(RDX, GrowableObjectArray::data_offset()),
RSI);
__ popq(CTX);
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}
@@ -2549,7 +2549,7 @@
ASSEMBLER_TEST_GENERATE(DoubleAbs, assembler) {
__ EnterDartFrame(0);
__ DoubleAbs(XMM0);
- __ LeaveFrameWithPP();
+ __ LeaveDartFrame();
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698