Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1943)

Side by Side Diff: runtime/vm/stack_frame_x64.h

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/stack_frame_mips.h ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_STACK_FRAME_X64_H_ 5 #ifndef VM_STACK_FRAME_X64_H_
6 #define VM_STACK_FRAME_X64_H_ 6 #define VM_STACK_FRAME_X64_H_
7 7
8 namespace dart { 8 namespace dart {
9 9
10 /* X64 Dart Frame Layout 10 /* X64 Dart Frame Layout
11 11
12 | | <- TOS 12 | | <- TOS
13 Callee frame | ... | 13 Callee frame | ... |
14 | saved PP | 14 | saved PP |
15 | callee's PC marker | 15 | callee's PC marker |
16 | saved RBP | (RBP of current frame) 16 | saved RBP | (RBP of current frame)
17 | saved PC | (PC of current frame) 17 | saved PC | (PC of current frame)
18 +--------------------+ 18 +--------------------+
19 Current frame | ... | <- RSP of current frame 19 Current frame | ... T| <- RSP of current frame
20 | first local | 20 | first local T|
21 | caller's PP | 21 | caller's PP T|
22 | PC marker | (current frame's code entry + offset) 22 | PC marker | (current frame's code entry + offset)
23 | caller's RBP | <- RBP of current frame 23 | caller's RBP | <- RBP of current frame
24 | caller's ret addr | (PC of caller frame) 24 | caller's ret addr | (PC of caller frame)
25 +--------------------+ 25 +--------------------+
26 Caller frame | last parameter | <- RSP of caller frame 26 Caller frame | last parameter | <- RSP of caller frame
27 | ... | 27 | ... |
28
29 T against a slot indicates it needs to be traversed during GC.
28 */ 30 */
29 31
30 static const int kDartFrameFixedSize = 4; // PC marker, RBP, PP, PC. 32 static const int kDartFrameFixedSize = 4; // PC marker, RBP, PP, PC.
31 static const int kSavedPcSlotFromSp = -1; 33 static const int kSavedPcSlotFromSp = -1;
32 34
35 static const int kFirstObjectSlotFromFp = -2; // Used by GC to traverse stack.
36
33 static const int kFirstLocalSlotFromFp = -3; 37 static const int kFirstLocalSlotFromFp = -3;
34 static const int kSavedCallerPpSlotFromFp = -2; 38 static const int kSavedCallerPpSlotFromFp = -2;
35 static const int kPcMarkerSlotFromFp = -1; 39 static const int kPcMarkerSlotFromFp = -1;
36 static const int kSavedCallerFpSlotFromFp = 0; 40 static const int kSavedCallerFpSlotFromFp = 0;
37 static const int kSavedCallerPcSlotFromFp = 1; 41 static const int kSavedCallerPcSlotFromFp = 1;
38 42
39 static const int kParamEndSlotFromFp = 1; // One slot past last parameter. 43 static const int kParamEndSlotFromFp = 1; // One slot past last parameter.
40 static const int kCallerSpSlotFromFp = 2; 44 static const int kCallerSpSlotFromFp = 2;
41 static const int kSavedAboveReturnAddress = 3; // Saved above return address. 45 static const int kSavedAboveReturnAddress = 3; // Saved above return address.
42 46
43 // Entry and exit frame layout. 47 // Entry and exit frame layout.
44 static const int kSavedContextSlotFromEntryFp = -10; 48 static const int kSavedContextSlotFromEntryFp = -9;
45 static const int kExitLinkSlotFromEntryFp = -9; 49 static const int kExitLinkSlotFromEntryFp = -8;
46 50
47 } // namespace dart 51 } // namespace dart
48 52
49 #endif // VM_STACK_FRAME_X64_H_ 53 #endif // VM_STACK_FRAME_X64_H_
50
OLDNEW
« no previous file with comments | « runtime/vm/stack_frame_mips.h ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698