Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: runtime/vm/instructions_x64_test.cc

Issue 63093003: Fix for issue 14790 - Crash when using dartium devtools (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/instructions.h" 9 #include "vm/instructions.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
(...skipping 10 matching lines...) Expand all
21 21
22 22
23 ASSEMBLER_TEST_RUN(Call, test) { 23 ASSEMBLER_TEST_RUN(Call, test) {
24 CallPattern call(test->entry(), test->code()); 24 CallPattern call(test->entry(), test->code());
25 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 25 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(),
26 call.TargetAddress()); 26 call.TargetAddress());
27 } 27 }
28 28
29 29
30 ASSEMBLER_TEST_GENERATE(Jump, assembler) { 30 ASSEMBLER_TEST_GENERATE(Jump, assembler) {
31 __ EnterDartFrame(0); // 20 bytes 31 __ EnterDartFrame(0); // 20 bytes
Ivan Posva 2013/11/07 22:11:58 ditto
siva 2013/11/07 23:08:19 Done.
32 __ JmpPatchable(&StubCode::InstanceFunctionLookupLabel(), PP); 32 __ JmpPatchable(&StubCode::InstanceFunctionLookupLabel(), PP);
33 __ JmpPatchable(&StubCode::AllocateArrayLabel(), PP); 33 __ JmpPatchable(&StubCode::AllocateArrayLabel(), PP);
34 __ LeaveFrameWithPP(); 34 __ LeaveDartFrame();
35 __ ret(); 35 __ ret();
36 } 36 }
37 37
38 38
39 ASSEMBLER_TEST_RUN(Jump, test) { 39 ASSEMBLER_TEST_RUN(Jump, test) {
40 JumpPattern jump1(test->entry() + 20, test->code()); 40 JumpPattern jump1(test->entry() + 20, test->code());
41 jump1.IsValid(); 41 jump1.IsValid();
42 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 42 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(),
43 jump1.TargetAddress()); 43 jump1.TargetAddress());
44 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes() + 20, 44 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes() + 20,
45 test->code()); 45 test->code());
46 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 46 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
47 jump2.TargetAddress()); 47 jump2.TargetAddress());
48 uword target1 = jump1.TargetAddress(); 48 uword target1 = jump1.TargetAddress();
49 uword target2 = jump2.TargetAddress(); 49 uword target2 = jump2.TargetAddress();
50 jump1.SetTargetAddress(target2); 50 jump1.SetTargetAddress(target2);
51 jump2.SetTargetAddress(target1); 51 jump2.SetTargetAddress(target1);
52 EXPECT_EQ(StubCode::AllocateArrayLabel().address(), 52 EXPECT_EQ(StubCode::AllocateArrayLabel().address(),
53 jump1.TargetAddress()); 53 jump1.TargetAddress());
54 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(), 54 EXPECT_EQ(StubCode::InstanceFunctionLookupLabel().address(),
55 jump2.TargetAddress()); 55 jump2.TargetAddress());
56 } 56 }
57 57
58 } // namespace dart 58 } // namespace dart
59 59
60 #endif // defined TARGET_ARCH_X64 60 #endif // defined TARGET_ARCH_X64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698