Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 63091: Prevent test shell editing events from getting to the webview delegate after ... (Closed)

Created:
11 years, 8 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin, dank
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Prevent test shell editing events from getting to the webview delegate after test shell shutdown. BUG=9486 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13294

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M webkit/tools/test_shell/test_shell.cc View 1 3 chunks +8 lines, -7 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
I was able to consistently repro the bug, and this fixes it for me.
11 years, 8 months ago (2009-04-07 22:04:29 UTC) #1
Evan Martin
lgtm if it doesn't break win/mac http://codereview.chromium.org/63091/diff/1001/4 File webkit/tools/test_shell/test_shell.cc (right): http://codereview.chromium.org/63091/diff/1001/4#newcode163 Line 163: PlatformShutdown(); thanks ...
11 years, 8 months ago (2009-04-07 22:07:29 UTC) #2
Evan Stade
11 years, 8 months ago (2009-04-07 22:28:24 UTC) #3
> lgtm if it doesn't break win/mac

I'll make sure trybots are go and then I'll be watching the tree carefully

http://codereview.chromium.org/63091/diff/1001/4
File webkit/tools/test_shell/test_shell.cc (right):

http://codereview.chromium.org/63091/diff/1001/4#newcode163
Line 163: PlatformShutdown();
On 2009/04/07 22:07:29, Evan Martin wrote:
> thanks for fixing these, they were driving me crazy every time i looked at the
> file

there's plenty more 4-space tabs where these came from D:

Powered by Google App Engine
This is Rietveld 408576698