Issue 63091: Prevent test shell editing events from getting to the webview delegate after ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63091: Prevent test shell editing events from getting to the webview delegate after ... (Closed)

Created:
11 years, 8 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin, dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Prevent test shell editing events from getting to the webview delegate after test shell shutdown. BUG=9486 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13294

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	webkit/tools/test_shell/test_shell.cc	View	1	3 chunks	+8 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

I was able to consistently repro the bug, and this fixes it for me.

11 years, 8 months ago (2009-04-07 22:04:29 UTC) #1

Evan Martin

lgtm if it doesn't break win/mac http://codereview.chromium.org/63091/diff/1001/4 File webkit/tools/test_shell/test_shell.cc (right): http://codereview.chromium.org/63091/diff/1001/4#newcode163 Line 163: PlatformShutdown(); thanks ...

11 years, 8 months ago (2009-04-07 22:07:29 UTC) #2