Move common GC state update code out of paint-server application

Source/core/rendering/svg/SVGRenderSupport.h

 /**
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.  All rights reserved.
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 69 matching lines @@
     static void mapLocalToContainer(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, TransformState&, bool* wasFixed = 0, const PaintInvalidationState* = 0);
     static const RenderObject* pushMappingToContainer(const RenderObject*, const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&);
 
     // Shared between SVG renderers and resources.
     static void applyStrokeStyleToContext(GraphicsContext*, const RenderStyle*, const RenderObject*);
     static void applyStrokeStyleToStrokeData(StrokeData*, const RenderStyle*, const RenderObject*);
 
     // Fill and/or stroke the provided |path|.
     static void fillOrStrokePath(GraphicsContext*, unsigned short resourceMode, const Path&);
 
+    // Transfer fill/stroke style (except paint server) to the GC.
+    static void updateGraphicsContext(GraphicsContext*, const RenderStyle*, const RenderObject&, unsigned resourceModeFlags);

[pdr., 2014/10/07 02:57:48]

This seems like a better fit as a protected member on RenderSVGResource.

[fs, 2014/10/07 12:34:20]

I can move it there in the interim, but longer term I think a better resting
place will be somewhere in core/paint/. I had a hope that this function would
even disintegrate (in most callsites it's known what resourceMode is after all),
but am not there yet (RenderingClipPathAsMask is one wrench that complicates
things).

+
     // Determines if any ancestor's transform has changed.
     static bool transformToRootChanged(RenderObject*);
 
     // FIXME: These methods do not belong here.
     static const RenderSVGRoot* findTreeRootObject(const RenderObject*);
 
     // Helper method for determining if a RenderObject marked as text (isText()== true)
     // can/will be rendered as part of a <text>.
     static bool isRenderableTextNode(const RenderObject*);
 
 private:
     static void updateObjectBoundingBox(FloatRect& objectBoundingBox, bool& objectBoundingBoxValid, RenderObject* other, FloatRect otherBoundingBox);
     static bool layoutSizeOfNearestViewportChanged(const RenderObject* start);
 };
 
 } // namespace blink
 
 #endif // SVGRenderSupport_h