Move common GC state update code out of paint-server application

Source/core/rendering/svg/RenderSVGShape.cpp

 /*
  * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2005, 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Google, Inc.
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
  * Copyright (C) 2011 Renata Hodovan <reni@webkit.org>
  * Copyright (C) 2011 University of Szeged
@@ skipping 187 matching lines @@
         return false;
 
     return resources->markerStart() || resources->markerMid() || resources->markerEnd();
 }
 
 void RenderSVGShape::fillShape(RenderStyle* style, GraphicsContext* context)
 {
     bool hasFallback;
     if (RenderSVGResource* fillPaintingResource = RenderSVGResource::requestPaintingResource(ApplyToFillMode, this, style, hasFallback)) {
         if (fillPaintingResource->applyResource(this, style, context, ApplyToFillMode)) {
+            SVGRenderSupport::updateGraphicsContext(context, style, *this, ApplyToFillMode);

[pdr., 2014/10/07 02:57:48]

Can we move this call into applyResource so it doesn't need to follow every
applyResource call?

[fs, 2014/10/07 12:34:20]

We can - at least for now. In ~2 CLs applyResource will turn into
preparePaintServer, and at that point updateGraphicsContext needs to be out of
it. It'll probably look nicer together w/ that change though.

             fillShape(context);
             fillPaintingResource->postApplyResource(context);
         } else if (hasFallback) {
             RenderSVGResourceSolidColor* fallbackResource = RenderSVGResource::sharedSolidPaintingResource();
             if (fallbackResource->applyResource(this, style, context, ApplyToFillMode)) {
+                SVGRenderSupport::updateGraphicsContext(context, style, *this, ApplyToFillMode);
                 fillShape(context);
                 fallbackResource->postApplyResource(context);
             }
         }
     }
 }
 
 void RenderSVGShape::strokeShape(RenderStyle* style, GraphicsContext* context)
 {
     bool hasFallback;
     if (RenderSVGResource* strokePaintingResource = RenderSVGResource::requestPaintingResource(ApplyToStrokeMode, this, style, hasFallback)) {
         if (strokePaintingResource->applyResource(this, style, context, ApplyToStrokeMode)) {
+            SVGRenderSupport::updateGraphicsContext(context, style, *this, ApplyToStrokeMode);
             strokeShape(context);
             strokePaintingResource->postApplyResource(context);
         } else if (hasFallback) {
             RenderSVGResourceSolidColor* fallbackResource = RenderSVGResource::sharedSolidPaintingResource();
             if (fallbackResource->applyResource(this, style, context, ApplyToStrokeMode)) {
+                SVGRenderSupport::updateGraphicsContext(context, style, *this, ApplyToStrokeMode);
                 strokeShape(context);
                 fallbackResource->postApplyResource(context);
             }
         }
     }
 }
 
 void RenderSVGShape::paint(PaintInfo& paintInfo, const LayoutPoint&)
 {
     ANNOTATE_GRAPHICS_CONTEXT(paintInfo, this);
@@ skipping 222 matching lines @@
     ASSERT(resources);
 
     RenderSVGResourceMarker* markerStart = resources->markerStart();
 
     SVGMarkerData markerData(m_markerPositions, markerStart ? markerStart->orientType() == SVGMarkerOrientAutoStartReverse : false);
     m_path->apply(&markerData, SVGMarkerData::updateFromPathElement);
     markerData.pathIsDone();
 }
 
 }