* Complete new store buffer on ia32. The store buffer now covers...

src/spaces.cc

 // Copyright 2006-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1564 matching lines @@
   for (int i = 0; i < kFreeListsLength; i++) {
     Address cur_addr = free_[i].head_node_;
     while (cur_addr != NULL) {
       FreeListNode* cur_node = FreeListNode::FromAddress(cur_addr);
       if (cur_node == node) return true;
       cur_addr = cur_node->next();
     }
   }
   return false;
 }
+
+
+void OldSpaceFreeList::Zap() {
+  for (int i = 0; i < kFreeListsLength; i++) {
+    Address cur_addr = free_[i].head_node_;
+    while (cur_addr != NULL) {
+      FreeListNode* cur_node = FreeListNode::FromAddress(cur_addr);
+      if (cur_node->IsByteArray()) {
+        ByteArray* ba = ByteArray::cast(cur_node);
+        Address payload_start = ba->GetDataStartAddress();

[Vyacheslav Egorov (Chromium), 2011/01/21 18:18:18]

This way you zap the next field of the cur_node!

It seems reasonable to teach FreeListNode Zap itself.

[Erik Corry, 2011/01/24 13:56:00]

Good catch.  Done.

+        Address payload_end = ba->address() + ba->Size();
+        for (Address cur = payload_start;
+             cur < payload_end;
+             cur += kPointerSize) {
+          *reinterpret_cast<Object**>(cur) = Smi::FromInt(0);
+        }
+      }
+      cur_addr = cur_node->next();
+    }
+  }
+}
+
+
+void FixedSizeFreeList::Zap() {
+  Address cur_addr = head_;
+  while (cur_addr != NULL && cur_addr != tail_) {
+    FreeListNode* cur_node = FreeListNode::FromAddress(cur_addr);

[Vyacheslav Egorov (Chromium), 2011/01/21 18:18:18]

cur_node->Zap();

see above.

[Erik Corry, 2011/01/24 13:56:00]

Done.

+    Address current = cur_addr + Map::kPointerFieldsBeginOffset;
+    Address limit = cur_addr + Map::kPointerFieldsEndOffset;
+    for (Address cur = current; cur < limit; cur += kPointerSize) {
+      *reinterpret_cast<Object**>(cur) = Smi::FromInt(0);
+    }
+    cur_addr = cur_node->next();
+  }
+}
 #endif
 
 
 FixedSizeFreeList::FixedSizeFreeList(AllocationSpace owner, int object_size)
     : owner_(owner), object_size_(object_size) {
   Reset();
 }
 
 
 void FixedSizeFreeList::Reset() {
@@ skipping 705 matching lines @@
 }
 
 
 void LargeObjectSpace::IterateDirtyRegions(ObjectSlotCallback copy_object) {
   LargeObjectIterator it(this);
   for (HeapObject* object = it.next(); object != NULL; object = it.next()) {
     // We only have code, sequential strings, or fixed arrays in large
     // object space, and only fixed arrays can possibly contain pointers to
     // the young generation.
     if (object->IsFixedArray()) {
-      Page* page = Page::FromAddress(object->address());
-      uint32_t marks = page->GetRegionMarks();
-
       // TODO(gc): we can no longer assume that LargePage is bigger than normal
       // page.
-      ASSERT(marks == Page::kAllRegionsDirtyMarks);

[Vyacheslav Egorov (Chromium), 2011/01/21 18:18:18]

Kill all constants/fields related to cardmarking. Not just their usages.

No mercy!

[Erik Corry, 2011/01/24 13:56:00]

Soon.

Nice time stamp.

-      USE(marks);
 
       Address start = object->address();
       Address object_end = start + object->Size();
       Heap::IteratePointersInDirtyRegion(start, object_end, copy_object);
     }
   }
 }
 
 
 void LargeObjectSpace::FreeUnmarkedObjects() {
@@ skipping 133 matching lines @@
   for (HeapObject* obj = obj_it.next(); obj != NULL; obj = obj_it.next()) {
     if (obj->IsCode()) {
       Code* code = Code::cast(obj);
       code_kind_statistics[code->kind()] += code->Size();
     }
   }
 }
 #endif  // DEBUG
 
 } }  // namespace v8::internal