Issue 63085: Attempt to fix crash that I don't fully understand and can't repro :(...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63085: Attempt to fix crash that I don't fully understand and can't repro :(... (Closed)

Created:
11 years, 8 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Attempt to fix crash that I don't fully understand and can't repro :( BUG=8933 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13357

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -2 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_popup_view_win.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 8 months ago (2009-04-08 15:56:00 UTC) #2

When I thought about this, I thought about it more in terms of intersecting the
window / damage rect with the current results rect, and then just bailing out
when there is nothing to do.  Anyway, this looks ok also, but it's all a bit
confusing.

Expand Messages | Collapse Messages