Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630813002: Replace OVERRIDE and FINAL with override and final in content/test/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
sky, Paweł Hajdan Jr.
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/test/[a-s]* BUG=417463 Committed: https://crrev.com/71fc3adc68bb1feb651b7f38cd0a4eb777186de9 Cr-Commit-Position: refs/heads/master@{#298228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -215 lines) Patch
M content/test/appcache_test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/browser_test_utils_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/content_browser_test_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/test/content_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/image_decoder_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/mock_google_streaming_server.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/mock_render_process.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/net/url_request_abort_on_end_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/net/url_request_slow_download_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/plugin/plugin_arguments_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_delete_plugin_in_deallocate_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_delete_plugin_in_stream_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_execute_stream_javascript.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url2_test.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url_test.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/plugin/plugin_geturl_test.h View 1 chunk +9 lines, -9 lines 0 comments Download
M content/test/plugin/plugin_javascript_open_popup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_new_fails_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_npobject_identity_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_npobject_lifetime_test.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/test/plugin/plugin_npobject_proxy_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_private_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_request_read_test.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/test/plugin/plugin_schedule_timer_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_setup_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_thread_async_call_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/plugin/plugin_window_size_test.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/plugin/plugin_windowless_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/ppapi/ppapi_test.h View 4 chunks +7 lines, -7 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_content_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_frame_navigation_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_media_stream_renderer_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_render_frame_host.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/test/test_render_frame_host_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_render_view_host.h View 3 chunks +64 lines, -64 lines 0 comments Download
M content/test/test_render_view_host_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_video_frame_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/test/test_web_contents.h View 4 chunks +21 lines, -21 lines 0 comments Download
M content/test/web_gesture_curve_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +18 lines, -18 lines 0 comments Download
M content/test/webrtc_content_browsertest_base.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
phajdan.jr@chromium.org: Please review changes in content/test module sky@chromium.org: Please review changes in content/test module
6 years, 2 months ago (2014-10-06 10:41:49 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years, 2 months ago (2014-10-06 12:26:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630813002/1
6 years, 2 months ago (2014-10-06 12:41:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 54e9b806b24e750b49e1947047d3057a5e42dadf
6 years, 2 months ago (2014-10-06 13:50:31 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 13:51:12 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/71fc3adc68bb1feb651b7f38cd0a4eb777186de9
Cr-Commit-Position: refs/heads/master@{#298228}

Powered by Google App Engine
This is Rietveld 408576698