Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 630803002: Replace OVERRIDE and FINAL with override and final in content/plugin/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/plugin/[a-s]* BUG=417463 Committed: https://crrev.com/be3b40c350851858ac1af80fbfc987691f5b96ae Cr-Commit-Position: refs/heads/master@{#298380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M content/plugin/plugin_channel.h View 3 chunks +8 lines, -8 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/webplugin_accelerated_surface_proxy_mac.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 2 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Anand Ratn (left samsung)
creis@chromium.org: Please review changes in content/plugin module
6 years, 2 months ago (2014-10-06 10:11:13 UTC) #2
Charlie Reis
LGTM
6 years, 2 months ago (2014-10-06 22:19:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630803002/1
6 years, 2 months ago (2014-10-07 02:17:36 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 04:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630803002/1
6 years, 2 months ago (2014-10-07 05:16:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79b1b0f98266eae21e99725b173489bc48d057d4
6 years, 2 months ago (2014-10-07 05:17:59 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 05:18:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be3b40c350851858ac1af80fbfc987691f5b96ae
Cr-Commit-Position: refs/heads/master@{#298380}

Powered by Google App Engine
This is Rietveld 408576698