Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 630793002: Add ValidationTooShort localized sring, in preparation for a message displayed when a form input co… (Closed)

Created:
6 years, 2 months ago by Bartek Nowierski
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add ValidationTooShort localized sring, in preparation for a message displayed when a form input content is shorter than minlength attribute. BUG=390485 Committed: https://crrev.com/0da08db83c07f4598c96b4487960cf44875996c2 Cr-Commit-Position: refs/heads/master@{#298823}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary change from test_blink_web_unit_test_support.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/app/strings/content_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
keishi
lgtm. You'll need reviews from one of the OWNERS
6 years, 2 months ago (2014-10-06 09:10:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-06 09:36:11 UTC) #4
tkent
https://codereview.chromium.org/630793002/diff/1/content/test/test_blink_web_unit_test_support.cc File content/test/test_blink_web_unit_test_support.cc (right): https://codereview.chromium.org/630793002/diff/1/content/test/test_blink_web_unit_test_support.cc#newcode215 content/test/test_blink_web_unit_test_support.cc:215: return base::ASCIIToUTF16("too short"); I don't think this change is ...
6 years, 2 months ago (2014-10-07 01:37:17 UTC) #5
Bartek Nowierski
https://codereview.chromium.org/630793002/diff/1/content/test/test_blink_web_unit_test_support.cc File content/test/test_blink_web_unit_test_support.cc (right): https://codereview.chromium.org/630793002/diff/1/content/test/test_blink_web_unit_test_support.cc#newcode215 content/test/test_blink_web_unit_test_support.cc:215: return base::ASCIIToUTF16("too short"); On 2014/10/07 01:37:17, tkent wrote: > ...
6 years, 2 months ago (2014-10-08 08:38:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630793002/20001
6 years, 2 months ago (2014-10-09 06:30:03 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d57e1f86b1568a9ebe33beab70010003fce9d660
6 years, 2 months ago (2014-10-09 07:21:22 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 07:22:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0da08db83c07f4598c96b4487960cf44875996c2
Cr-Commit-Position: refs/heads/master@{#298823}

Powered by Google App Engine
This is Rietveld 408576698