Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 630753002: Replacing the OVERRIDE with override and FINAL with final in cloud_print (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in cloud_print This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/de3401d659d40f0078f904babcb6b7a01b9f102d Cr-Commit-Position: refs/heads/master@{#298210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -61 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_request.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_requester.h View 1 chunk +7 lines, -7 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/cloud_print_xmpp_listener.h View 1 chunk +4 lines, -4 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.h View 1 chunk +34 lines, -34 lines 0 comments Download
M cloud_print/gcp20/prototype/privet_http_server.h View 1 chunk +5 lines, -5 lines 0 comments Download
M cloud_print/service/service_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/service_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/service/win/setup_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 06:35:12 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-10-06 07:10:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630753002/1
6 years, 2 months ago (2014-10-06 07:11:27 UTC) #5
MRV
On 2014/10/06 07:10:22, Vitaly Buka wrote: > lgtm Thanks Mr. Vitaly Buka for LGTM
6 years, 2 months ago (2014-10-06 07:14:46 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as a51ea241def81ae2b2f52a90ae0f4881ca80d41d
6 years, 2 months ago (2014-10-06 09:17:20 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 09:18:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de3401d659d40f0078f904babcb6b7a01b9f102d
Cr-Commit-Position: refs/heads/master@{#298210}

Powered by Google App Engine
This is Rietveld 408576698