Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 630743005: Replace OVERRIDE and FINAL with override and final in content/child/[a-s]* (Closed)

Created:
6 years, 2 months ago by Anand Ratn (left samsung)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cmumford, darin-cc_chromium.org, dgrogan, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, jsbell+idb_chromium.org, kinuko+serviceworker, kinuko+fileapi, michaeln, mkwst+moarreviews-ipc_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in content/child/[a-s]* BUG=417463 WIP Committed: https://crrev.com/f3d1998aa54747da9e4ac5fa0e8063f1eef7e3c7 Cr-Commit-Position: refs/heads/master@{#298446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -329 lines) Patch
M content/child/appcache/appcache_backend_proxy.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/child/appcache/appcache_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/appcache_frontend_impl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/blink_platform_impl.h View 2 chunks +11 lines, -11 lines 0 comments Download
M content/child/blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blink_platform_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/browser_font_resource_trusted.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/child/child_histogram_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/child_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_shared_bitmap_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/child_thread.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/db_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/file_system_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/webfilesystem_impl.h View 3 chunks +13 lines, -13 lines 0 comments Download
M content/child/fileapi/webfilewriter_base_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/geofencing/geofencing_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/geofencing/geofencing_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/indexed_db/indexed_db_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/indexed_db/webidbcursor_impl_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/child/npapi/np_channel_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/npapi/npobject_proxy.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/child/npapi/npobject_stub.h View 1 chunk +5 lines, -5 lines 0 comments Download
M content/child/npapi/plugin_stream_url.h View 1 chunk +11 lines, -11 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/child/npapi/plugin_url_fetcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 2 chunks +19 lines, -19 lines 0 comments Download
M content/child/power_monitor_broadcast_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/power_monitor_broadcast_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/quota_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/quota_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/quota_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 6 chunks +14 lines, -14 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_message_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/site_isolation_policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/socket_stream_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/socket_stream_dispatcher.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/thread_safe_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/touch_fling_gesture_curve.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/touch_fling_gesture_curve_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_socket_stream_handle_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/child/web_url_loader_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 8 chunks +16 lines, -16 lines 0 comments Download
M content/child/webcrypto/nss/aes_cbc_nss.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/nss/aes_gcm_nss.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/webcrypto/nss/aes_key_nss.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/webcrypto/nss/aes_kw_nss.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/nss/hmac_nss.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/nss/key_nss.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/rsa_key_nss.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/nss/rsa_oaep_nss.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/webcrypto/nss/rsa_ssa_nss.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/nss/sha_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/openssl/aes_cbc_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/aes_ctr_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/aes_gcm_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/aes_key_openssl.h View 1 chunk +7 lines, -7 lines 0 comments Download
M content/child/webcrypto/openssl/aes_kw_openssl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/openssl/key_openssl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_oaep_openssl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_ssa_openssl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/sha_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webmessageportchannel_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/websocket_bridge.h View 1 chunk +4 lines, -4 lines 0 comments Download
M content/child/websocket_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webthread_impl.h View 2 chunks +8 lines, -8 lines 0 comments Download
M content/child/webthread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/worker_thread_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Ratn (left samsung)
jochen@chromium.org: Please review changes in content/child module
6 years, 2 months ago (2014-10-06 14:01:20 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-07 09:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630743005/1
6 years, 2 months ago (2014-10-07 10:59:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 853cf261fb2828015f1cbe641753a85d97d73410
6 years, 2 months ago (2014-10-07 12:59:27 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 13:00:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3d1998aa54747da9e4ac5fa0e8063f1eef7e3c7
Cr-Commit-Position: refs/heads/master@{#298446}

Powered by Google App Engine
This is Rietveld 408576698