Issue 6307004: DOMUI: Don't call SetString for fields that doesn't exist in the Password Manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6307004: DOMUI: Don't call SetString for fields that doesn't exist in the Password Manager. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI: Don't call SetString for fields that doesn't exist in the Password Manager. BUG=69145 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71616

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	chrome/browser/dom_ui/options/password_manager_handler.cc	View		1 chunk	+0 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

Hi James, could you review this to me? http://codereview.chromium.org/6307004/diff/1/chrome/browser/dom_ui/options/password_manager_handler.cc File chrome/browser/dom_ui/options/password_manager_handler.cc (left): http://codereview.chromium.org/6307004/diff/1/chrome/browser/dom_ui/options/password_manager_handler.cc#oldcode47 chrome/browser/dom_ui/options/password_manager_handler.cc:47: localized_strings->SetString("passwordsShowButton", ...

9 years, 11 months ago (2011-01-18 01:04:48 UTC) #1

LGTM

Expand Messages | Collapse Messages