replace OVERRIDE and FINAL with override and final in chromecast/

replace OVERRIDE and FINAL with override and final in chromecast/

R=damienv@chromium.org,dcheng@chromium.org
BUG=417463
Committed: https://crrev.com/1ee2dbd5ff96e1eea6d6b53cf8282faa5a4ed4cd
Cr-Commit-Position: refs/heads/master@{#298250}

[Mostyn Bramley-Moore, 2014-10-06 15:23:02]

@damienv: can you give this a thumbs-up?

The script I used to make this change is mentioned in the comments over here:

[damienv1, 2014-10-06 15:48:14]

damienv@chromium.org changed reviewers:
+ gunsch@chromium.org, lcwu@chromium.org

[damienv1, 2014-10-06 15:52:12]

lgtm

[Mostyn Bramley-Moore, 2014-10-06 15:55:04]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-10-06 15:56:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630663003/1

[gunsch, 2014-10-06 15:57:12]

lgtm, this is going to make our unforking diff sadder :(

[Mostyn Bramley-Moore, 2014-10-06 16:00:20]

On 2014/10/06 15:57:12, gunsch wrote:
> lgtm, this is going to make our unforking diff sadder :(

Would it help if I gave you a bash script to run in your other branch/tree that
makes the same changes as here?

[gunsch, 2014-10-06 16:10:36]

On 2014/10/06 16:00:20, Mostyn Bramley-Moore wrote:
> On 2014/10/06 15:57:12, gunsch wrote:
> > lgtm, this is going to make our unforking diff sadder :(
> 
> Would it help if I gave you a bash script to run in your other branch/tree
that
> makes the same changes as here?

Unfortunately, our other tree is still:
* Forked from M37 TOT
* Building against GCC 4.5.3 (for reasons currently outside of our control)

so I don't know if that will help.

We might be able to get away with something like adding a "#define override
OVERRIDE" so we can reduce our diff, though.

[lcwu1, 2014-10-06 16:12:41]

On 2014/10/06 16:00:20, Mostyn Bramley-Moore wrote:
> On 2014/10/06 15:57:12, gunsch wrote:
> > lgtm, this is going to make our unforking diff sadder :(
> 
> Would it help if I gave you a bash script to run in your other branch/tree
that
> makes the same changes as here?

Having a script to help cleaning up our internal git projects is surely welcome.
But I think our imminent issue here is that we are still using gcc-4.5.3 for
cross-compiling for the chromecast devices. So basically we will need to put a
temporary macro definition that defines 'override' as 'OVERRIRDE' (or maybe
no-op) before we upgrade our compiler to support C++11.

[gunsch, 2014-10-06 16:37:30]

On 2014/10/06 16:12:41, lcwu1 wrote:
> On 2014/10/06 16:00:20, Mostyn Bramley-Moore wrote:
> > On 2014/10/06 15:57:12, gunsch wrote:
> > > lgtm, this is going to make our unforking diff sadder :(
> > 
> > Would it help if I gave you a bash script to run in your other branch/tree
> that
> > makes the same changes as here?
> 
> Having a script to help cleaning up our internal git projects is surely
welcome.
> But I think our imminent issue here is that we are still using gcc-4.5.3 for
> cross-compiling for the chromecast devices. So basically we will need to put a
> temporary macro definition that defines 'override' as 'OVERRIRDE' (or maybe
> no-op) before we upgrade our compiler to support C++11.

It was fairly easy to clean up internally with a new temporary macro definition.
I think we'll be fine. Thanks for the cleanup.

[commit-bot: I haz the power, 2014-10-06 16:43:41]

Committed patchset #1 (id:1) as db29d8abd92e11bbaeed98dea1228d05073651c9

[commit-bot: I haz the power, 2014-10-06 16:44:15]

Patchset 1 (id:??) landed as
https://crrev.com/1ee2dbd5ff96e1eea6d6b53cf8282faa5a4ed4cd
Cr-Commit-Position: refs/heads/master@{#298250}