Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 630603003: Replacing the OVERRIDE with override in chrome/renderer (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Mostyn Bramley-Moore, sky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and in chrome/renderer This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/54170a07df0ff322b35a933a0604856d5594a1e8 Cr-Commit-Position: refs/heads/master@{#299042}

Patch Set 1 #

Patch Set 2 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -257 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +34 lines, -34 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/content_settings_observer.h View 2 chunks +18 lines, -18 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_frame_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/tab_finder.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/webstore_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/external_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/cast_transport_sender_ipc.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/mock_webrtc_logging_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/net/net_error_helper.h View 2 chunks +17 lines, -17 lines 0 comments Download
M chrome/renderer/net/net_error_helper_core_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M chrome/renderer/net/net_error_page_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/net/prescient_networking_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_load_histograms.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/chrome_renderer_pepper_host_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_drm_renderer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_font_file_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_fullscreen_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_menu_host.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_shared_memory_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prefetch_helper.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/prerender/prerender_dispatcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/prerender/prerender_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prerender/prerender_media_load_deferrer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prerender/prerenderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/principals_extension_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/search_bouncer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/security_filter_peer.h View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/translate/translate_helper_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/translate/translate_script_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/tts_dispatcher.h View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 07:20:00 UTC) #2
MRV
On 2014/10/06 07:20:00, MRV wrote: > PTAL Dear Mr. Sky PTAL
6 years, 2 months ago (2014-10-06 16:14:05 UTC) #3
MRV
On 2014/10/06 16:14:05, MRV wrote: > On 2014/10/06 07:20:00, MRV wrote: > > PTAL > ...
6 years, 2 months ago (2014-10-07 03:40:02 UTC) #4
MRV
On 2014/10/07 03:40:02, MRV wrote: > On 2014/10/06 16:14:05, MRV wrote: > > On 2014/10/06 ...
6 years, 2 months ago (2014-10-08 12:32:15 UTC) #5
MRV
On 2014/10/08 12:32:15, MRV wrote: > On 2014/10/07 03:40:02, MRV wrote: > > On 2014/10/06 ...
6 years, 2 months ago (2014-10-10 00:43:06 UTC) #7
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-10 01:09:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630603003/20001
6 years, 2 months ago (2014-10-10 01:09:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-10 02:08:27 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:08:57 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54170a07df0ff322b35a933a0604856d5594a1e8
Cr-Commit-Position: refs/heads/master@{#299042}

Powered by Google App Engine
This is Rietveld 408576698