Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_types.h

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_types.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_types.h b/chrome/browser/ui/autofill/autofill_dialog_types.h
index 9c96b8bb97347df4c4482a3ccde74dc1b62e8dd2..52f2e8626d39a672aa0c4eda468e5d0042aec68d 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_types.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_types.h
@@ -28,9 +28,11 @@ class AutofillField;
// dialog.
struct DetailInput {
enum Length {
- SHORT, // Short inputs share a line with other short inputs. [ CVC ][ Zip ]
- LONG, // Long inputs will be given their own full line. [ City ]
- NONE, // Input will not be shown.
+ SHORT, // Shares a line with other short inputs, like display: inline.
+ SHORT_EOL, // Like SHORT but starts a new line directly afterward. Used to
+ // separate groups of short inputs into different lines.
+ LONG, // Will be given its own full line, like display: block.
+ NONE, // Input will not be shown.
};
// Used to determine which inputs share lines when laying out.
@@ -38,8 +40,8 @@ struct DetailInput {
ServerFieldType type;
- // Placeholder text resource ID.
- int placeholder_text_rid;
+ // Text shown when the input is at its default state (e.g. empty).
+ base::string16 placeholder_text;
// A number between 0 and 1.0 that describes how much of the horizontal space
// in the row should be allotted to this input. 0 is equivalent to 1.

Powered by Google App Engine
This is Rietveld 408576698