chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm - Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/autofill/autofill_section_container.mm ('K') | « chrome/browser/ui/cocoa/autofill/autofill_section_container.mm ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.h » ('j') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

index a20e8431c2640d24b27cb9d866000b8a3d9caa00..2c1a4c1389af5798f3bfc2bed9b81c5cf6d7a1a7 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm

@@ -16,6 +16,7 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "testing/gtest_mac.h"

#include "testing/platform_test.h"

+#include "ui/base/l10n/l10n_util.h"

#include "ui/base/models/combobox_model.h"

#include "ui/base/models/simple_menu_model.h"

#import "ui/base/test/ui_cocoa_test_helper.h"

@@ -119,7 +120,7 @@ TEST_F(AutofillSectionContainerTest, OutputMatchesDefinition) {

const DetailInput kTestInputs[] = {

{ DetailInput::LONG,

EMAIL_ADDRESS,

- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },

};

autofill::MonthComboboxModel comboModel;

@@ -184,7 +185,7 @@ TEST_F(AutofillSectionContainerTest, FieldsAreInitiallyValid) {

const DetailInput kTestInputs[] = {

{ DetailInput::LONG,

EMAIL_ADDRESS,

- IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH },

};

@@ -212,7 +213,9 @@ TEST_F(AutofillSectionContainerTest, ControllerInformsValidity) {

using namespace testing;

const DetailInput kTestInputs[] = {

- { DetailInput::LONG, EMAIL_ADDRESS, IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL },

+ { DetailInput::LONG,

+ EMAIL_ADDRESS,

+ l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_PLACEHOLDER_EMAIL) },

{ DetailInput::SHORT, CREDIT_CARD_EXP_MONTH }

};