chrome/browser/ui/autofill/autofill_dialog_types.h - Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_types.h

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: let's try this again, android Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc ('K') | « chrome/browser/ui/autofill/autofill_dialog_i18n_input_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_types.cc » ('j') | chrome/browser/ui/views/autofill/autofill_dialog_views.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_types.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_types.h b/chrome/browser/ui/autofill/autofill_dialog_types.h

index 1651770aa366857b73197b5ef12b968822b610e2..429213e60f468db02040792b110e49475b83949b 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_types.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_types.h

@@ -35,8 +35,8 @@ struct DetailInput {

ServerFieldType type;

- // Placeholder text resource ID.

- int placeholder_text_rid;

+ // Text shown when the input is at its default state (e.g. empty).

+ base::string16 placeholder_text;

Evan Stade 2013/12/02 17:57:33 I acknowledge the necessity of this change, but ar

Dan Beam 2013/12/02 22:37:54 clang nor git cl presubmit are whining. i think t

// A number between 0 and 1.0 that describes how much of the horizontal space

// in the row should be allotted to this input. 0 is equivalent to 1.