Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5725)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_common.h

Issue 63053003: Ask libaddressinput for address components to use in requestAutocomplete(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: let's try this again, android Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_common.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_common.h b/chrome/browser/ui/autofill/autofill_dialog_common.h
index 91ce21c3ffe471c36e01f87c7a6221884ddd2281..a6e8a56c1dd63b7a830489642209f5c42ec4207b 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_common.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_common.h
@@ -34,7 +34,11 @@ bool DetailInputMatchesField(DialogSection section,
bool IsCreditCardType(ServerFieldType type);
// Constructs |inputs| from template data for a given |dialog_section|.
-void BuildInputsForSection(DialogSection dialog_section, DetailInputs* inputs);
+// |country_region| specifies the country/region code that the inputs should be
+// built for.
+void BuildInputsForSection(DialogSection dialog_section,
+ DetailInputs* inputs,
+ const std::string& country_region);
// Returns the AutofillMetrics::DIALOG_UI_*_ITEM_ADDED metric corresponding
// to the |section|.
@@ -46,9 +50,9 @@ AutofillMetrics::DialogUiEvent DialogSectionToUiItemAddedEvent(
AutofillMetrics::DialogUiEvent DialogSectionToUiSelectionChangedEvent(
DialogSection section);
-// We hardcode some values. In particular, we don't yet allow the user to change
-// the country: http://crbug.com/247518
-string16 GetHardcodedValueForType(ServerFieldType type);
+// Returns the initial value for an input |type| in |country_code|.
+base::string16 GetInitialValueForType(ServerFieldType type,
+ const std::string& country_code);
} // namespace common
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698