Ask libaddressinput for address components to use in requestAutocomplete().

chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 85 matching lines @@
 // Return YES if this is a section that contains CC info. (And, more
 // importantly, a potential CVV field)
 - (BOOL)isCreditCardSection;
 
 // Create properly styled label for section. Autoreleased.
 - (NSTextField*)makeDetailSectionLabel:(NSString*)labelText;
 
 // Create a button offering input suggestions.
 - (MenuButton*)makeSuggestionButton;
 
-// Create a view with all inputs requested by |delegate_|. Autoreleased.
-- (LayoutView*)makeInputControls;
+// Create a view with all inputs requested by |delegate_| and resets |input_|.

[groby-ooo-7-16, 2013/12/05 02:56:10]

Should probably mention that it replaces the old inputs in the view hierarchy,
too. 

That's why I'd rather return a LayoutView - this function starts doing too many
things.

+- (void)makeInputControls;
 
 // Refresh all field icons based on |delegate_| status.
 - (void)updateFieldIcons;
 
 // Refresh the enabled/disabled state of all input fields.
 - (void)updateEditability;
 
 @end
 
 @implementation AutofillSectionContainer
@@ skipping 33 matching lines @@
   if (![[self view] isHidden])
     [self validateFor:autofill::VALIDATE_EDIT];
 
   // Always request re-layout on state change.
   id delegate = [[view_ window] windowController];
   if ([delegate respondsToSelector:@selector(requestRelayout)])
     [delegate performSelector:@selector(requestRelayout)];
 }
 
 - (void)loadView {
-  // Keep a list of weak pointers to DetailInputs.
-  const autofill::DetailInputs& inputs =
-      delegate_->RequestedFieldsForSection(section_);
-
-  // Reverse the order of all the inputs.
-  for (int i = inputs.size() - 1; i >= 0; --i) {
-    detailInputs_.push_back(&(inputs[i]));
-  }
-
-  // Then right the reversal in each row.
-  std::vector<const autofill::DetailInput*>::iterator it;
-  for (it = detailInputs_.begin(); it < detailInputs_.end(); ++it) {
-    std::vector<const autofill::DetailInput*>::iterator start = it;
-    while (it != detailInputs_.end() &&
-           (*it)->length != autofill::DetailInput::LONG) {
-      ++it;
-    }
-    std::reverse(start, it);
-  }
-
-  inputs_.reset([[self makeInputControls] retain]);
+  [self makeInputControls];
   string16 labelText = delegate_->LabelForSection(section_);
   label_.reset(
       [[self makeDetailSectionLabel:base::SysUTF16ToNSString(labelText)]
           retain]);
 
   suggestButton_.reset([[self makeSuggestionButton] retain]);
   suggestContainer_.reset([[AutofillSuggestionContainer alloc] init]);
 
   view_.reset([[AutofillSectionView alloc] initWithFrame:NSZeroRect]);
   [self setView:view_];
@@ skipping 90 matching lines @@
   [validationDelegate_ updateMessageForField:field];
 }
 
 - (void)didChange:(id)sender {
   [self textfieldEditedOrActivated:sender edited:YES];
 }
 
 - (void)didEndEditing:(id)sender {
   delegate_->FocusMoved();
   [validationDelegate_ hideErrorBubble];
+
+  AutofillPopUpButton* popup = base::mac::ObjCCast<AutofillPopUpButton>(sender);
+  if (popup) {
+    // Add one to account for the spacer at the top of the list.
+    int index = [popup indexOfSelectedItem] + 1;
+    delegate_->ComboboxItemSelected([self fieldTypeForControl:popup], index);
+  }
+
   [self validateFor:autofill::VALIDATE_EDIT];
   [self updateEditability];
 }
 
 - (void)updateSuggestionState {
   const autofill::SuggestionState& suggestionState =
       delegate_->SuggestionStateForSection(section_);
   // TODO(estade): use |vertically_compact_text| when it fits.
   const base::string16& text = suggestionState.horizontally_compact_text;
   showSuggestions_ = suggestionState.visible;
@@ skipping 181 matching lines @@
                                          toHaveTrait:NSBoldFontMask]];
   [label setStringValue:labelText];
   [label setEditable:NO];
   [label setBordered:NO];
   [label setDrawsBackground:NO];
   [label sizeToFit];
   return label.autorelease();
 }
 
 - (void)updateAndClobber:(BOOL)shouldClobber {
+  if (shouldClobber)
+    [self makeInputControls];
+
   const autofill::DetailInputs& updatedInputs =
       delegate_->RequestedFieldsForSection(section_);
 
   for (autofill::DetailInputs::const_iterator iter = updatedInputs.begin();
        iter != updatedInputs.end();
        ++iter) {
     NSControl<AutofillInputField>* field = [inputs_ viewWithTag:iter->type];
     DCHECK(field);
 
     if (shouldClobber || [field isDefault]) {
@@ skipping 37 matching lines @@
   [[button cell] setImage:image
            forButtonState:image_button_cell::kDisabledState];
 
   // ImageButtonCell's cellSize is not working. (http://crbug.com/298501)
   [button setFrameSize:[image size]];
   return button.autorelease();
 }
 
 // TODO(estade): we should be using Chrome-style constrained window padding
 // values.
-- (LayoutView*)makeInputControls {
+- (void)makeInputControls {
+  detailInputs_.clear();
+
+  // Keep a list of weak pointers to DetailInputs.
+  const autofill::DetailInputs& inputs =
+      delegate_->RequestedFieldsForSection(section_);
+
+  // Reverse the order of all the inputs.
+  for (int i = inputs.size() - 1; i >= 0; --i) {
+    detailInputs_.push_back(&(inputs[i]));
+  }
+
+  // Then right the reversal in each row.
+  std::vector<const autofill::DetailInput*>::iterator it;
+  for (it = detailInputs_.begin(); it < detailInputs_.end(); ++it) {
+    std::vector<const autofill::DetailInput*>::iterator start = it;
+    while (it != detailInputs_.end() &&
+           (*it)->length != autofill::DetailInput::LONG) {
+      ++it;
+    }
+    std::reverse(start, it);
+  }
+
   base::scoped_nsobject<LayoutView> view([[LayoutView alloc] init]);
   [view setLayoutManager:
       scoped_ptr<SimpleGridLayout>(new SimpleGridLayout(view))];
   SimpleGridLayout* layout = [view layoutManager];
 
   int column_set_id = 0;
   for (size_t i = 0; i < detailInputs_.size(); ++i) {
     const autofill::DetailInput& input = *detailInputs_[i];
 
     if (input.length == autofill::DetailInput::LONG)
@@ skipping 29 matching lines @@
          [popup addItemWithTitle:
              base::SysUTF16ToNSString(inputModel->GetItemAt(i))];
       }
       [popup setDefaultValue:base::SysUTF16ToNSString(
           inputModel->GetItemAt(inputModel->GetDefaultIndex()))];
       control.reset(popup.release());
     } else {
       base::scoped_nsobject<AutofillTextField> field(
           [[AutofillTextField alloc] init]);
       [[field cell] setPlaceholderString:
-          l10n_util::GetNSStringWithFixup(input.placeholder_text_rid)];
+          base::SysUTF16ToNSString(input.placeholder_text)];
       [field setDefaultValue:@""];
       control.reset(field.release());
     }
     [control setFieldValue:base::SysUTF16ToNSString(input.initial_value)];
     [control sizeToFit];
     [control setTag:input.type];
     [control setInputDelegate:self];
     // Hide away fields that cannot be edited.
     if (kColumnSetId == -1) {
       [control setFrame:NSZeroRect];
       [control setHidden:YES];
     }
     layout->AddView(control);
 
-    if (input.length == autofill::DetailInput::LONG)
+    if (input.length == autofill::DetailInput::LONG ||
+        input.length == autofill::DetailInput::SHORT_EOL) {
       ++column_set_id;
+    }
   }
 
   [self updateFieldIcons];

[groby-ooo-7-16, 2013/12/05 02:56:10]

This must be called _after_ updating inputs_ - updateFieldIcons updates the
fields in inputs_

-  return view.autorelease();
+
+  if (inputs_)
+    [[self view] replaceSubview:inputs_ with:view];
+
+  inputs_ = view;
 }
 
 - (void)updateFieldIcons {
   autofill::FieldValueMap fieldValues;
   for (NSControl<AutofillInputField>* input in [inputs_ subviews]) {
     DCHECK([input isKindOfClass:[NSControl class]]);
     DCHECK([input conformsToProtocol:@protocol(AutofillInputField)]);
     autofill::ServerFieldType fieldType = [self fieldTypeForControl:input];
     NSString* value = [input fieldValue];
     fieldValues[fieldType] = base::SysNSStringToUTF16(value);
   }
 
   autofill::FieldIconMap fieldIcons = delegate_->IconsForFields(fieldValues);
   for (autofill::FieldIconMap::const_iterator iter = fieldIcons.begin();
        iter!= fieldIcons.end(); ++iter) {
     AutofillTextField* textfield = base::mac::ObjCCastStrict<AutofillTextField>(
         [inputs_ viewWithTag:iter->first]);
     [[textfield cell] setIcon:iter->second.ToNSImage()];
   }
 }
 
 - (void)updateEditability {
 
   base::scoped_nsobject<NSMutableArray> controls([[NSMutableArray alloc] init]);
   [self addInputsToArray:controls];
   for (NSControl<AutofillInputField>* control in controls.get()) {
     autofill::ServerFieldType type = [self fieldTypeForControl:control];
     const autofill::DetailInput* input = [self detailInputForType:type];

[groby-ooo-7-16, 2013/12/05 02:56:10]

Why can this now be zero?

-    [control setEnabled:delegate_->InputIsEditable(*input, section_)];
+    if (input)
+      [control setEnabled:delegate_->InputIsEditable(*input, section_)];
   }
 }
 
 @end
 
 
 @implementation AutofillSectionContainer (ForTesting)
 
 - (NSControl*)getField:(autofill::ServerFieldType)type {
   return [inputs_ viewWithTag:type];
@@ skipping 15 matching lines @@
 - (void)activateFieldForInput:(const autofill::DetailInput&)input {
   if ([self detailInputForType:input.type] != &input)
     return;
 
   NSControl<AutofillInputField>* field = [inputs_ viewWithTag:input.type];
   [[field window] makeFirstResponder:field];
   [self textfieldEditedOrActivated:field edited:NO];
 }
 
 @end