Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 630453002: Revert of Enabling two tests that were disabled in app_shell_browsertests. (Closed)

Created:
6 years, 2 months ago by lfg
Modified:
6 years, 2 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Enabling two tests that were disabled in app_shell_browsertests. (patchset #1 id:1 of https://codereview.chromium.org/623193002/) Reason for revert: The RenderProcessHost may not be destroyed because the message to destroy it may be queued in the message loop after the test pass message. Original issue's description: > Enabling two tests that were disabled in app_shell_browsertests. > > We can enable those tests now that crbug.com/419020 is fixed. > > BUG=352293 > > Committed: https://crrev.com/9b10e4b077ee7106ab57d4728c5199a03638701a > Cr-Commit-Position: refs/heads/master@{#298062} TBR=fsamuel@chromium.org NOTREECHECKS=true NOTRY=true BUG=352293 Committed: https://crrev.com/9939e951c13993fedba520815a1f7a5222c3f0d7 Cr-Commit-Position: refs/heads/master@{#298086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lfg
Created Revert of Enabling two tests that were disabled in app_shell_browsertests.
6 years, 2 months ago (2014-10-03 20:15:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630453002/1
6 years, 2 months ago (2014-10-03 20:16:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2c9ca65682e6210520ad1504f8ebcbffd3510da4
6 years, 2 months ago (2014-10-03 20:17:22 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 20:18:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9939e951c13993fedba520815a1f7a5222c3f0d7
Cr-Commit-Position: refs/heads/master@{#298086}

Powered by Google App Engine
This is Rietveld 408576698