Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 630423002: [turbofan] Reenable value numbering. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Reenable value numbering. Value numbering is now limited to eliminatable operators (i.e. operators that don't throw and don't write), and uses linear probing instead of separate chaining. TEST=unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24452

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes #

Patch Set 3 : Win fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -39 lines) Patch
M src/compiler/pipeline.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/value-numbering-reducer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/compiler/value-numbering-reducer.cc View 1 2 3 chunks +89 lines, -24 lines 0 comments Download
M test/unittests/compiler/value-numbering-reducer-unittest.cc View 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-07 13:34:23 UTC) #1
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-08 07:37:35 UTC) #5
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-08 07:37:35 UTC) #6
Sven Panne
lgtm
6 years, 2 months ago (2014-10-08 07:51:33 UTC) #7
Michael Starzinger
https://codereview.chromium.org/630423002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/630423002/diff/1/src/compiler/pipeline.cc#newcode293 src/compiler/pipeline.cc:293: // TODO(turbofan): Value numbering disabled for now. The TODO ...
6 years, 2 months ago (2014-10-08 07:53:02 UTC) #9
Benedikt Meurer
https://codereview.chromium.org/630423002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/630423002/diff/1/src/compiler/pipeline.cc#newcode293 src/compiler/pipeline.cc:293: // TODO(turbofan): Value numbering disabled for now. On 2014/10/08 ...
6 years, 2 months ago (2014-10-08 08:05:28 UTC) #10
Benedikt Meurer
6 years, 2 months ago (2014-10-08 08:07:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24452 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698