tools/gn/generate_test_gn_data.cc - Issue 630403003: Clean up ifdef around FilePath creation in /src/tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/generate_test_gn_data.cc

Issue 630403003: Clean up ifdef around FilePath creation in /src/tools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/generate_test_gn_data.cc

diff --git a/tools/gn/generate_test_gn_data.cc b/tools/gn/generate_test_gn_data.cc

index fe4fdc75732a3c3f918fadf21d22d93084375e64..6489df40a8bc0477815046796fe0db7547ee32f1 100644

--- a/tools/gn/generate_test_gn_data.cc

+++ b/tools/gn/generate_test_gn_data.cc

@@ -17,11 +17,7 @@ int files_written = 0;

int targets_written = 0;

base::FilePath UTF8ToFilePath(const std::string& s) {

-#if defined(OS_WIN)

- return base::FilePath(base::UTF8ToWide(s));

-#else

- return base::FilePath(s);

-#endif

+return base::FilePath::FromUTF8Unsafe(s);

}

std::string FilePathToUTF8(const base::FilePath& path) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »