Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 630403003: Clean up ifdef around FilePath creation in /src/tools (Closed)

Created:
6 years, 2 months ago by anujsharma
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, MRV
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up ifdef around FilePath creation in /src/tools BUG=102853 Committed: https://crrev.com/658266caa15fcc0b5158029b6c4441c831040d91 Cr-Commit-Position: refs/heads/master@{#298532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M tools/gn/generate_test_gn_data.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 2 months ago (2014-10-07 13:10:14 UTC) #2
brettw
lgtm
6 years, 2 months ago (2014-10-07 16:30:39 UTC) #3
anujsharma
On 2014/10/07 16:30:39, brettw wrote: > lgtm Thanks brettw for lgtm.
6 years, 2 months ago (2014-10-07 17:55:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630403003/1
6 years, 2 months ago (2014-10-07 17:56:16 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 431dee102db809f4f1124aa8416e52bad2c6bbe7
6 years, 2 months ago (2014-10-07 18:52:24 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 18:54:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/658266caa15fcc0b5158029b6c4441c831040d91
Cr-Commit-Position: refs/heads/master@{#298532}

Powered by Google App Engine
This is Rietveld 408576698