Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 630403002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/serviceworkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 630403002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/serviceworkers (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.h ('k') | Source/modules/serviceworkers/ServiceWorkerContainerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index 3f01664328a0f054e589c8e25a4f33b13135c5e6..8369a9a519cc7c5f07882706121eb3fa9ab3e545 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -61,14 +61,14 @@ public:

: m_resolver(resolver)

, m_adapter(m_resolver) { }

virtual ~GetRegistrationCallback() { }

- virtual void onSuccess(WebServiceWorkerRegistration* registration) OVERRIDE

+ virtual void onSuccess(WebServiceWorkerRegistration* registration) override

{

if (registration)

m_adapter.onSuccess(registration);

else if (m_resolver->executionContext() && !m_resolver->executionContext()->activeDOMObjectsAreStopped())

m_resolver->resolve();

}

- virtual void onError(WebServiceWorkerError* error) OVERRIDE { m_adapter.onError(error); }

+ virtual void onError(WebServiceWorkerError* error) override { m_adapter.onError(error); }

private:

RefPtr<ScriptPromiseResolver> m_resolver;

CallbackPromiseAdapter<ServiceWorkerRegistration, ServiceWorkerError> m_adapter;