Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 630403002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/serviceworkers (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/modules/serviceworkers This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183393

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -121 lines) Patch
M Source/modules/serviceworkers/Body.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/Cache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/modules/serviceworkers/CacheStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/CacheStorage.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/serviceworkers/CacheTest.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M Source/modules/serviceworkers/ExtendableEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/FetchHeaderList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchResponseData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Headers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Headers.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/InstallEvent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerThread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/WaitUntilObserver.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 12:20:16 UTC) #2
MRV
On 2014/10/07 12:20:16, MRV wrote: > PTAL Dear mr.jochen, please review my patch
6 years, 2 months ago (2014-10-08 00:39:21 UTC) #4
Mike West
rs lgtm, but you'll need a ServiceWorker OWNER. How about horo@?
6 years, 2 months ago (2014-10-08 05:20:27 UTC) #6
MRV
On 2014/10/08 05:20:27, Mike West wrote: > rs lgtm, but you'll need a ServiceWorker OWNER. ...
6 years, 2 months ago (2014-10-08 05:32:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630403002/1
6 years, 2 months ago (2014-10-08 06:31:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/16960)
6 years, 2 months ago (2014-10-08 06:38:39 UTC) #11
horo
lgtm
6 years, 2 months ago (2014-10-08 06:54:47 UTC) #12
MRV
On 2014/10/08 06:54:47, horo wrote: > lgtm Thanks mr. horo for reviewing.
6 years, 2 months ago (2014-10-08 07:17:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630403002/1
6 years, 2 months ago (2014-10-08 07:18:42 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 07:23:25 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183393

Powered by Google App Engine
This is Rietveld 408576698