Support StringCharCodeAt in hydrogen/lithium.

src/ia32/lithium-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1724 matching lines @@
 
 LInstruction* LChunkBuilder::DoStoreNamedGeneric(HStoreNamedGeneric* instr) {
   LOperand* obj = UseFixed(instr->object(), edx);
   LOperand* val = UseFixed(instr->value(), eax);
 
   LStoreNamedGeneric* result = new LStoreNamedGeneric(obj, val);
   return MarkAsCall(result, instr);
 }
 
 
+LInstruction* LChunkBuilder::DoStringCharCodeAt(HStringCharCodeAt* instr) {
+  return AssignEnvironment(AssignPointerMap(DefineAsRegister(

[fschneider, 2011/01/14 12:06:11]

I'd rather split this into multiple statements to improve readability.

LOperand* object = UseRegister(instr->string());
LOperand* index = UseRegisterOrConstant(instr->index());
...

+      new LStringCharCodeAt(UseRegister(instr->string()),
+                            UseRegisterOrConstant(instr->index())))));
+}
+
+
+LInstruction* LChunkBuilder::DoStringLength(HStringLength* instr) {
+  return DefineAsRegister(

[fschneider, 2011/01/14 12:06:11]

I'd also split this into 2 statement here.

+      new LStringLength(UseRegisterAtStart(instr->value())));
+}
+
+
 LInstruction* LChunkBuilder::DoArrayLiteral(HArrayLiteral* instr) {
   return MarkAsCall(DefineFixed(new LArrayLiteral, eax), instr);
 }
 
 
 LInstruction* LChunkBuilder::DoObjectLiteral(HObjectLiteral* instr) {
   return MarkAsCall(DefineFixed(new LObjectLiteral, eax), instr);
 }
 
 
@@ skipping 118 matching lines @@
 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
   HEnvironment* outer = current_block_->last_environment()->outer();
   current_block_->UpdateEnvironment(outer);
   return NULL;
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32