Add stack trace to the promise reject callback.

Add stack trace to the promise reject callback.

R=aandrey@chromium.org
BUG=chromium:393913
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=24432

[aandrey, 2014-10-07 10:32:07]

https://codereview.chromium.org/630373003/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/630373003/diff/1/include/v8.h#newcode4218
include/v8.h:4218: PromiseRejectEvent event,
I think we'd better extract these to smth like v8::PromiseMessage, so that we
could extend it later w/o breaking the embedder's build.

E.g. we may also need to pass ScriptOrigin and MessageLocation in the future
(similar to v8::Message).

[aandrey, 2014-10-07 10:49:06]

https://codereview.chromium.org/630373003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/630373003/diff/1/src/isolate.cc#newcode2277
src/isolate.cc:2277: capture_stack_trace_for_uncaught_exceptions_ &&
value->IsJSObject()) {
I think we can drop the capture_stack_trace_for_uncaught_exceptions_ check:
1) will be still handled correctly below,
2) this flag may be false, but we could still have the stack collected.

https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc#newc...
test/cctest/test-api.cc:17965: CHECK_EQ(0, promise_reject_frame_count);
CHECK_EQ(-1, promise_reject_line_number);

[Yang, 2014-10-07 10:59:43]

On 2014/10/07 10:49:06, aandrey wrote:
> https://codereview.chromium.org/630373003/diff/1/src/isolate.cc
> File src/isolate.cc (right):
> 
> https://codereview.chromium.org/630373003/diff/1/src/isolate.cc#newcode2277
> src/isolate.cc:2277: capture_stack_trace_for_uncaught_exceptions_ &&
> value->IsJSObject()) {
> I think we can drop the capture_stack_trace_for_uncaught_exceptions_ check:
> 1) will be still handled correctly below,
> 2) this flag may be false, but we could still have the stack collected.
> 
> https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc
> File test/cctest/test-api.cc (right):
> 
>
https://codereview.chromium.org/630373003/diff/1/test/cctest/test-api.cc#newc...
> test/cctest/test-api.cc:17965: CHECK_EQ(0, promise_reject_frame_count);
> CHECK_EQ(-1, promise_reject_line_number);

New patch set addressing the comments uploaded.

[aandrey, 2014-10-07 11:06:09]

lgtm

https://codereview.chromium.org/630373003/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/630373003/diff/20001/include/v8.h#newcode4226
include/v8.h:4226: Handle<Promise> GetPromise() { return promise_; }
const methods

[aandrey, 2014-10-07 11:09:21]

https://codereview.chromium.org/630373003/diff/20001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/630373003/diff/20001/include/v8.h#newcode4227
include/v8.h:4227: PromiseRejectEvent GetEvent() { return event_; }
also use V8_INLINE?

[Yang, 2014-10-07 12:04:04]

Committed patchset #3 (id:40001) manually as 24432 (presubmit successful).