Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: chrome/browser/extensions/extension_message_service.h

Issue 63036: Fix a crash where the ResourceMessageFilter is deleted (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_service.h
===================================================================
--- chrome/browser/extensions/extension_message_service.h (revision 13541)
+++ chrome/browser/extensions/extension_message_service.h (working copy)
@@ -9,6 +9,7 @@
#include <string>
#include "base/lock.h"
+#include "chrome/common/notification_observer.h"
class ExtensionView;
class ResourceMessageFilter;
@@ -23,7 +24,7 @@
// port: an IPC::Message::Sender interface through which we communicate to a
// process. We use MessageFilters for this since that allows us to send our
// messages on the IO thread.
-class ExtensionMessageService {
+class ExtensionMessageService : public NotificationObserver {
public:
// Returns the message service for the given context. Messages can only
// be sent within a single context.
@@ -54,8 +55,10 @@
// Called to let us know that a renderer has been started.
void RendererReady(ResourceMessageFilter* port);
- // Called to let us know that a renderer is going away.
- void RendererShutdown(ResourceMessageFilter* port);
+ // NotificationObserver interface.
+ void Observe(NotificationType type,
+ const NotificationSource& source,
+ const NotificationDetails& details);
private:
// A map of extension ID to the render_process_id that the extension lives in.

Powered by Google App Engine
This is Rietveld 408576698