Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4049)

Unified Diff: chrome/browser/worker_host/worker_service.h

Issue 63036: Fix a crash where the ResourceMessageFilter is deleted (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/worker_host/worker_service.h
===================================================================
--- chrome/browser/worker_host/worker_service.h (revision 13541)
+++ chrome/browser/worker_host/worker_service.h (working copy)
@@ -9,6 +9,7 @@
#include "base/basictypes.h"
#include "base/singleton.h"
+#include "chrome/common/notification_observer.h"
#include "googleurl/src/gurl.h"
namespace IPC {
@@ -19,7 +20,7 @@
class WorkerProcessHost;
class ResourceMessageFilter;
-class WorkerService {
+class WorkerService : public NotificationObserver {
public:
// Returns the WorkerService singleton.
static WorkerService* GetInstance();
@@ -34,9 +35,10 @@
// should be forwarded to the worker process.
void ForwardMessage(const IPC::Message& message);
- // Called by ResourceMessageFilter when it's destructed so that all the
- // WorkerProcessHost objects can remove their pointers to it.
- void RendererShutdown(ResourceMessageFilter* filter);
+ // NotificationObserver interface.
+ void Observe(NotificationType type,
+ const NotificationSource& source,
+ const NotificationDetails& details);
private:
friend struct DefaultSingletonTraits<WorkerService>;

Powered by Google App Engine
This is Rietveld 408576698