Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7863)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 63036: Fix a crash where the ResourceMessageFilter is deleted (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/extension_message_service.cc ('K') | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | chrome/browser/renderer_host/safe_browsing_resource_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/resource_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter.cc (revision 13541)
+++ chrome/browser/renderer_host/resource_message_filter.cc (working copy)
@@ -139,9 +139,11 @@
}
ResourceMessageFilter::~ResourceMessageFilter() {
- WorkerService::GetInstance()->RendererShutdown(this);
- ExtensionMessageService::GetInstance(request_context_.get())->
- RendererShutdown(this);
+ // Let interested observers know we are being deleted.
+ NotificationService::current()->Notify(
+ NotificationType::RESOURCE_MESSAGE_FILTER_SHUTDOWN,
+ Source<ResourceMessageFilter>(this),
+ NotificationService::NoDetails());
if (handle())
base::CloseProcessHandle(handle());
« chrome/browser/extensions/extension_message_service.cc ('K') | « chrome/browser/renderer_host/resource_dispatcher_host.cc ('k') | chrome/browser/renderer_host/safe_browsing_resource_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698