Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 630333002: Rewrite line endings from CRLF to LF for a bunch of files. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
arv+watch_chromium.org, ben+ash_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, eroman, extensions-reviews_chromium.org, grt+watch_chromium.org, jam, kalyank, mkwst+moarreviews-ipc_chromium.org, mmenke, sadrul, tdanderson+views_chromium.org, tfarina, wfh+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rewrite line endings from CRLF to LF for a bunch of files. There's a lot of other files with CRLF line endings in test data, third_party, and tools. Out of caution, those files have been left unchanged, in case anything depends on the CRLF being present. BUG=420796 TBR=darin@chromium.org, rsleevi@chromium.org, sky@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/d42a8f8372389ff80a2f0f55b8826318a6ed2c93

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+956 lines, -956 lines) Patch
M chrome/browser/extensions/extension_message_bubble.h View 1 chunk +34 lines, -34 lines 0 comments Download
M chrome/browser/google/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/file_path_verifier_win_unittest.cc View 1 chunk +40 lines, -40 lines 0 comments Download
M chrome/browser/resources/extensions_infobar.css View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/resources/net_internals/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_app_handler.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/ash/OWNERS View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/omnibox/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search_engines/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/OWNERS View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_applications/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/eula/oem.css View 1 chunk +51 lines, -51 lines 0 comments Download
M chrome/tools/tracing/trace.html View 1 chunk +395 lines, -395 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.h View 1 chunk +87 lines, -87 lines 0 comments Download
M components/google/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M content/child/webcrypto/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M courgette/third_party/README.chromium View 1 chunk +23 lines, -23 lines 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.h View 1 chunk +71 lines, -71 lines 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.cc View 1 chunk +107 lines, -107 lines 0 comments Download
M net/test/net_test_suite.cc View 1 chunk +67 lines, -67 lines 0 comments Download
M third_party/modp_b64/OWNERS View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/sheriffing/app.yaml View 1 chunk +17 lines, -17 lines 0 comments Download
M ui/README.chromium View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/v2/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/OWNERS View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/corewm/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/README.chromium View 1 chunk +2 lines, -2 lines 0 comments Download
M win8/metro_driver/DEPS View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
TBRing reviewers per git cl upload's suggestions.
6 years, 2 months ago (2014-10-07 03:21:18 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d42a8f8372389ff80a2f0f55b8826318a6ed2c93 Cr-Commit-Position: refs/heads/master@{#298348}
6 years, 2 months ago (2014-10-07 03:23:36 UTC) #3
dcheng
Committed patchset #1 (id:1) manually as d42a8f8372389ff80a2f0f55b8826318a6ed2c93.
6 years, 2 months ago (2014-10-07 03:23:55 UTC) #4
Ryan Sleevi
6 years, 2 months ago (2014-10-07 03:27:41 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698