Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 63033010: Mojo's C++ and JavaScript bindings should produce identical messages (Closed)

Created:
7 years, 1 month ago by abarth-chromium
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo's C++ and JavaScript bindings should produce identical messages After this CL, the JavaScript and C++ bindings produce identical binary messages for the test_sample "frobinate" workload. BUG=317398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236147

Patch Set 1 #

Patch Set 2 : Works except for the total message length #

Patch Set 3 : Binary compatibility #

Patch Set 4 : Binary matches #

Patch Set 5 : Remove a copy #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -9 lines) Patch
M gin/test/file_runner.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/bindings/js/codec.js View 1 2 3 4 4 chunks +12 lines, -2 lines 0 comments Download
M mojo/public/bindings/js/codec_unittests.js View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A mojo/public/bindings/js/test/hexdump.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
M mojo/public/bindings/sample/mojom/sample_service.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/bindings/sample/sample_test.cc View 1 2 3 chunks +24 lines, -0 lines 0 comments Download
M mojo/public/bindings/sample/sample_test.js View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
abarth-chromium
7 years, 1 month ago (2013-11-19 04:29:54 UTC) #1
DaveMoore
lgtm
7 years, 1 month ago (2013-11-19 17:52:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/63033010/110001
7 years, 1 month ago (2013-11-19 18:41:55 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
7 years, 1 month ago (2013-11-19 20:31:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/63033010/110001
7 years, 1 month ago (2013-11-19 20:38:13 UTC) #5
commit-bot: I haz the power
Failed to apply patch for gin/test/file_runner.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-19 20:38:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/63033010/320001
7 years, 1 month ago (2013-11-20 02:05:30 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-20 04:37:10 UTC) #8
Message was sent while issue was closed.
Change committed as 236147

Powered by Google App Engine
This is Rietveld 408576698