Issue 63033008: Move delivery of upload 'progress' events to XMLHttpRequestUpload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63033008: Move delivery of upload 'progress' events to XMLHttpRequestUpload. (Closed)

Created:
7 years, 1 month ago by sof

Modified:
7 years, 1 month ago

Reviewers:
tyoshino (SeeGerritForStatus), eseidel, Nate Chapin, abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Move delivery of upload 'progress' events to XMLHttpRequestUpload. Have the XMLHttpRequestUpload object handle dispatching of its 'progress' events, and at the same time keep track of the last progress data reported. While the latter state isn't directly made use of here, follow-on changes to handle 'progress' events during XHR request errors will depend on having it available. R= BUG=315488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162254

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -1 line)			Patch
M	Source/core/xml/XMLHttpRequest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XMLHttpRequestUpload.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/core/xml/XMLHttpRequestUpload.cpp	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sof

At your leisure, please take a look. (Split out from crrev.com/61793010)

7 years, 1 month ago (2013-11-18 22:27:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/63033008/1

7 years, 1 month ago (2013-11-18 23:11:04 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages