Issue 63033003: Fix try-catch for sure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 63033003: Fix try-catch for sure (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
regis, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix try-catch for sure Fix scoping of user-defined exception and stack trace variables in catch clause. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=30003

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -79 lines)			Patch
M	runtime/vm/parser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	28 chunks	+52 lines, -79 lines	0 comments	Download
M	tests/language/try_catch_test.dart	View		2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM, as good as yesterday :-) https://codereview.chromium.org/63033003/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/63033003/diff/1/runtime/vm/parser.cc#newcode6859 runtime/vm/parser.cc:6859: // 3) unconditional ...

7 years, 1 month ago (2013-11-06 21:59:55 UTC) #3

hausner

Thank you. https://codereview.chromium.org/63033003/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/63033003/diff/1/runtime/vm/parser.cc#newcode6859 runtime/vm/parser.cc:6859: // 3) unconditional JUMP to the end ...

7 years, 1 month ago (2013-11-06 22:07:11 UTC) #4

hausner

7 years, 1 month ago (2013-11-06 22:07:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30003 (presubmit successful).

Expand Messages | Collapse Messages

Issue 63033003: Fix try-catch for sure (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages