Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 630323003: [Issue - 116972] - Save File Problem with tar.bz (Closed)

Created:
6 years, 2 months ago by arun87.kumar
Modified:
6 years, 2 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, xam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Downloading a file with ".tar.bz" extension mulitple times resulted in incorrect filename where ordinal number was suffixed to "tar" instead of filename as below. Actual - file.tar(1).bz Expected - file(1).tar.bz This happened because "bz" was not recognized as double extension. BUG=116972 Committed: https://crrev.com/fad66c3012d0c95b447f5bc46da7602f57188dfe Cr-Commit-Position: refs/heads/master@{#298789}

Patch Set 1 #

Patch Set 2 : Added id to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_path_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
arun87.kumar
Hi all, I have made changes to fix the above issue as per asanka's comments. ...
6 years, 2 months ago (2014-10-07 03:32:31 UTC) #2
asanka
code lgtm Please revise the commit message as per http://dev.chromium.org/developers/contributing-code#TOC-Change-List-Description-Structured-Elements How are you uploading your ...
6 years, 2 months ago (2014-10-07 03:52:35 UTC) #3
asanka
On 2014/10/07 03:52:35, asanka wrote: > code lgtm > > Please revise the commit message ...
6 years, 2 months ago (2014-10-07 03:56:13 UTC) #4
arun87.kumar
On 2014/10/07 03:56:13, asanka wrote: > On 2014/10/07 03:52:35, asanka wrote: > > code lgtm ...
6 years, 2 months ago (2014-10-07 04:37:35 UTC) #5
rvargas (doing something else)
lgtm
6 years, 2 months ago (2014-10-08 00:38:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630323003/1
6 years, 2 months ago (2014-10-08 00:39:56 UTC) #8
rvargas (doing something else)
Arun, You are not yet listed as an authorized contributor in the current Samsung CLA. ...
6 years, 2 months ago (2014-10-08 00:50:17 UTC) #10
arun87.kumar
On 2014/10/08 00:50:17, rvargas wrote: > Arun, > > You are not yet listed as ...
6 years, 2 months ago (2014-10-08 06:26:52 UTC) #11
asanka
On 2014/10/08 00:50:17, rvargas wrote: > Arun, > > You are not yet listed as ...
6 years, 2 months ago (2014-10-08 15:49:19 UTC) #12
lgombos
On 2014/10/08 00:50:17, rvargas wrote: > You are not yet listed as an authorized contributor ...
6 years, 2 months ago (2014-10-08 18:06:24 UTC) #13
lgombos
6 years, 2 months ago (2014-10-08 18:06:58 UTC) #14
rvargas (doing something else)
On 2014/10/08 18:06:58, lgombos wrote: Interesting. There are two lists... one for "Samsung" and another ...
6 years, 2 months ago (2014-10-08 18:51:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/630323003/20001
6 years, 2 months ago (2014-10-08 18:54:39 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 779b5fa66f86ead21c0718e6422981f65a5ef1f4
6 years, 2 months ago (2014-10-09 04:50:52 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 04:52:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fad66c3012d0c95b447f5bc46da7602f57188dfe
Cr-Commit-Position: refs/heads/master@{#298789}

Powered by Google App Engine
This is Rietveld 408576698